ci: run CI on pull_request events (cover fork PRs)#80
Merged
Conversation
This was referenced Jul 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Node CI workflow triggers on
on: [push]only. Apushevent for a PR opened from a fork fires in the contributor's fork, not in this repo — and with nopull_requesttrigger,Eyevinn/node-srtnever runs CI for fork PRs. The result is that external contributions show "no checks reported" (e.g. #77, #78), while a PR from an in-repo branch (#76) gets CI purely because its branch lives here. Every external contributor's build currently goes unverified — on a native addon where the build is the risky part.Fix
Add a
pull_requesttrigger so the build/test matrix runs for PRs, including those from forks:pull_request(notpull_request_target) checks out the PR's code with a read-onlyGITHUB_TOKENand no access to secrets, which is the safe default for a build/test job on untrusted fork code. No job steps change.Scope
CI-config only — no runtime, native, or build-script changes.
Opened by the node-srt community triage bot (CI-config fix). Once CI is green here, this is a Tier A change that can be merged.