Repository navigation
Add VTX Admin telemetry script for B&W radios - #41
Conversation
|
UI for review 
|
CapnBry
left a comment
CapnBry
left a comment
There was a problem hiding this comment.
Man this is amazing. Works perfectly as far as the functionality goes, just a couple notes.
Channel 0
If I booth with VTXAdmin off, launch the admin script, go into menu, shows channel 0. If I set the band, the channel stays 0 but the main screen and the top right show the correct channel, not 0. Same happens if I have VTX admin on and set the band to off then leave the menu and come back the channel displays 0. Maybe the channel and power should be hidden line power hides the pit mode item if the VTX Admin is off?
Also should this follow the same naming as the lua has with Band/Enable or whatever it says?
See other requested changes in comments
Test build for 4f028e1
|
ELRVTX shows the VTX tuning, power and the six 6POS presets on a 128x64 dashboard; ENTER opens a menu with the colour widget's settings (VTX fields, Send VTx, 6POS quick change, presets). The VTX Admin core moves to SCRIPTS/ELRS/vtx/ so the widget and the telemetry script share it, along with the presets, now stored in SCRIPTS/ELRS/vtx/presets.txt. The core ticks from background() so the 6POS automation runs whatever page is shown. To fit B&W memory the menu is table-driven, dialogs load only when needed, and the session drops discovery fields it no longer needs. The loader reports why a script failed to load.
Move the active-preset match into VTXAdmin.activePreset() so the B&W dashboard and the colour widget use one copy.
d208cc2 to
1d8c190
Compare
|
CapnBry
left a comment
CapnBry
left a comment
There was a problem hiding this comment.
Looks great, just have a minor cosmetic question about the 6POS title. I'm approving but you make the call on the comment below and this:
The menu now labels VTX Admin off as Disabled (to match the tools version), but the top bar shows it as "Off". I don't know if we should change this because Disabled gets close to the navigation title and that could look jumbled? I'm for leaving it how it is here but I just wanted to bring it up in case you felt differently.
| { kind = NUMBER, label = "Power Level", key = "power", vtx = true, min = 0, max = 8, names = POWER_NAMES }, | ||
| { kind = TOGGLE, label = "Pitmode", key = "pitmode", vtx = true }, | ||
| { kind = SEND }, | ||
| { kind = FOLDER, label = "6POS Quick Change", page = { title = "6POS Quick Change", rows = quickChangeRows } }, |
There was a problem hiding this comment.
I've noticed that the "Sending" and "Loading" text runs over the "6POS Quick Change" title bar, do you think it would be acceptable to make it title = Quick Change? The label version definitely should have the 6POS part but the shorter version for the submenu would not run into it.
There was a problem hiding this comment.
Addressed in 116eb90 on master: the page title is now "Quick Change" and the row label keeps "6POS".
|
Keeping "Off" in the top bar, since "Disabled" collides with the page title. The Band field already says Disabled. |
No description provided.