feat(configuration): 일정 일괄 수정 API가 여러 일정을 받도록 변경 #133 - #134
Merged
Conversation
/schedules/bulk 이 단건만 받던 것을 배열 요청으로 바꾸고, 한 트랜잭션에서 전부 수정하도록 ScheduleUseCase.update 를 updateAll 로 교체한다. 제목이 하나라도 없으면 404 로 전체 롤백하고, 빈 배열은 400 으로 거부한다. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
🚫 Excluded labels (none allowed) (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kusuri12-09
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PATCH /api/schedule/v11/schedules/bulk이 이름대로 여러 일정을 한 요청으로 수정한다.Related Issue
Current vs Improved
Before — 단건만 받고, N개 수정하려면 N번 호출 (중간 실패 시 부분 반영)
{ "title": "원서 접수", "startAt": { ... }, "endAt": { ... } }After — 배열로 받고 한 트랜잭션에서 전부 처리
[ { "title": "원서 접수", "startAt": { ... }, "endAt": { ... } }, { "title": "1차 발표", "startAt": { ... }, "endAt": { ... } } ]응답
data도 같은 순서의 배열이 된다. 경로·인증(ADMIN)·날짜 객체 형식·dayOfWeek검증은 그대로.Implementation
ScheduleUseCase.update(title, startAt, endAt)→updateAll(schedules: List<Schedule>): List<Schedule>. 어댑터 DTO 대신 이미 있는 도메인Schedule을 그대로 파라미터로 쓴다.ScheduleService.updateAll은 기존@Transactional안에서 제목별로 조회·저장하므로, 하나라도 없으면SCHEDULE_NOT_FOUND(404) 로 전체 롤백된다.INVALID_REQUEST_PARAM(400).ponytail:주석으로findAllByTitleIn승급 경로를 남겼다.Impact
Testing
bazel test //systems/configuration/...14/14 통과Risk
Checklist
🤖 Generated with Claude Code