Conversation
DB_URL/DB_USERNAME/DB_PASSWORD 가 빠지면 컨테이너 안의 localhost:3306 으로 붙으려다 connection refused 가 나서 원인을 찾기 어려웠다. 다른 서비스와 동일하게 기본값 없이 선언해 누락 시 기동 로그에 바로 드러나도록 하고, 필요한 환경변수를 .env.example 로 문서화한다. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
🚫 Excluded labels (none allowed) (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kusuri12-09
previously approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Root Cause
admin-bootstrap/application.yaml의 datasource 만 유일하게${DB_URL:jdbc:mysql://localhost:3306/admin_db...}처럼 로컬 기본값을 가지고 있었다.localhost:3306으로 접속을 시도해Communications link failure만 남고, 무엇이 빠졌는지 로그로 알 수 없었다.systems/admin/.env.example이 없어 필요한 변수 목록도 문서화되어 있지 않았다 (run-service.sh는systems/admin/.env를 요구한다)..env.admin은 저장소에서 확인할 수 없어 실제 누락 여부는 배포 담당자 확인이 필요하다.Fix Description
DB_URL,DB_USERNAME,DB_PASSWORD의 기본값을 제거해 identity / application / notification / configuration 과 동일하게 선언.systems/admin/.env.example추가 (DB, admission 정원, storage 변수.schema.sql선적용이 필요하다는 안내 포함).Testing
Driver com.mysql.cj.jdbc.Driver claims to not accept jdbcUrl, ${DB_URL}로 즉시 실패하며 미해석 변수명이 로그에 드러남.schema.sql적용 후.env.example값으로 기동 →Started AdminBootstrapApplication확인 (ddl-auto: validate통과,schema.sql이 현재 엔티티와 일치함도 확인).Risk & Impact
systems/admin/.env를 만들어야 한다.배포 담당자 확인 사항
.env.admin에DB_URL,DB_USERNAME,DB_PASSWORD가 있고 host 가localhost가 아닌지.admin_db에admin-bootstrap/src/main/resources/schema.sql이 적용되어 있는지 (admin 은 Flyway 미사용, 서비스별 Flyway 마이그레이션 및 configuration 실행 설정 개선 #111 참고).Checklist
🤖 Generated with Claude Code