add link to main application in error messages for private spaces - #1371
Open
valentinRyckaert wants to merge 2 commits into
Open
add link to main application in error messages for private spaces#1371valentinRyckaert wants to merge 2 commits into
valentinRyckaert wants to merge 2 commits into
Conversation
fbacall
requested changes
Aug 26, 2026
| unless policy(Space.current_space).shown? | ||
| if current_user | ||
| flash[:alert] = t('private_space.no_authorized') | ||
| flash[:alert] = t('private_space.no_authorized', base_url: TeSS::Config.base_url).html_safe |
Member
There was a problem hiding this comment.
Just pass the actual link rather than the base_url, e.g. root_path here.
| raise Pundit::NotAuthorizedError | ||
| else | ||
| flash[:alert] = t('private_space.needs_sign_in') | ||
| flash[:alert] = t('private_space.needs_sign_in', base_url: TeSS::Config.base_url).html_safe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
If a user try to access directly a private space without sign in or without enough rights, they get an error and need to change the URL by hand to go to the main application.
Checklist