Skip to content

disable migratewallet rpc for v29 #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomt1664 wants to merge 1 commit into
base: elements-29.x
Choose a base branch
from
+6 −0
Open

disable migratewallet rpc for v29 #1563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/wallet/rpc/wallet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,6 +781,7 @@ RPCHelpMan simulaterawtransaction()
static RPCHelpMan migratewallet()
{
return RPCHelpMan{"migratewallet",
"\nDISABLED\n"
"\nMigrate the wallet to a descriptor wallet.\n"
"A new wallet backup will need to be made.\n"
"\nThe migration process will create a backup of the wallet before migrating. This backup\n"
Expand Down Expand Up @@ -819,6 +820,10 @@ static RPCHelpMan migratewallet()
wallet_name = request.params[0].get_str();
}

throw JSONRPCError(RPC_WALLET_ERROR,
"migratewallet is disabled in this version.");

/* ELEMENTS v29: disable migratewallet
SecureString wallet_pass;
wallet_pass.reserve(100);
if (!request.params[1].isNull()) {
Expand All @@ -842,6 +847,7 @@ static RPCHelpMan migratewallet()
r.pushKV("backup_path", res->backup_path.utf8string());

return r;
*/
},
};
}
Expand Down
Loading