Skip to content

rpc: fix fields description in a man in 'decodepsbt'#1560

Open
RuslanProgrammer wants to merge 2 commits into
ElementsProject:masterfrom
RuslanProgrammer:rpc-changes
Open

rpc: fix fields description in a man in 'decodepsbt'#1560
RuslanProgrammer wants to merge 2 commits into
ElementsProject:masterfrom
RuslanProgrammer:rpc-changes

Conversation

@RuslanProgrammer

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/rpc/rawtransaction.cpp Outdated
Comment on lines 1156 to 1157
{RPCResult::Type::NUM, "inputs_modifiable", /*optional=*/true, "Whether inputs can be modified"},
{RPCResult::Type::NUM, "outputs_modifiable", /*optional=*/true, "Whether outputs can be modified"},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should also be BOOL

Suggested change
{RPCResult::Type::NUM, "inputs_modifiable", /*optional=*/true, "Whether inputs can be modified"},
{RPCResult::Type::NUM, "outputs_modifiable", /*optional=*/true, "Whether outputs can be modified"},
{RPCResult::Type::BOOL, "inputs_modifiable", /*optional=*/true, "Whether inputs can be modified"},
{RPCResult::Type::BOOL, "outputs_modifiable", /*optional=*/true, "Whether outputs can be modified"},

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants