Skip to content

Cherry-pick PRs #6172 and #6203 to staging - #6204

Open
EdgeClaws wants to merge 2 commits into
EdgeApp:stagingfrom
EdgeClaws:jared/cherry-pick-6172-6203-to-staging
Open

EdgeClaws wants to merge 2 commits into
EdgeApp:stagingfrom
EdgeClaws:jared/cherry-pick-6172-6203-to-staging

Conversation

@EdgeClaws

@EdgeClaws EdgeClaws commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Cherry-picks the merged changes from develop into staging:

Validation

  • Both merge commits cherry-picked cleanly with first-parent mainline semantics.
  • Each cherry-picked commit is patch-equivalent to its source merge commit.
  • All changed Maestro YAML files parse successfully.
  • git diff --check passes.
  • Worktree is clean.

Testing

  • Tested on iOS
  • Tested on Android

Worked on by

  • EdgeClaws

…-fixes

fix(maestro): repair recent existing test flows
@JP0P
JP0P self-requested a review September 8, 2026 22:25

@JP0P JP0P left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking correctness findings. Reviewed both backports and staging compatibility: each commit is patch-equivalent to its source merge (#6172 and #6203), and the resulting runtime source, native projects, dependencies, and Maestro flows match the merged develop version. Identifier producers and consumers agree; no old underscore wallet IDs remain.

Validation: all 27 changed flows passed Maestro check-syntax; git diff --check passed; CI lint, TypeScript, and Jest passed. This review did not rerun device E2E tests.

Nonblocking commit hygiene: the flattened cherry-picks inherit 68- and 77-character merge subjects. The repository convention says "max 50 chars" (AGENTS.md); suggested subjects are Backport Maestro fixes from #6172 and Backport test ID separators from #6203.

Review completed with dev agents review skill (minorly adapted for codex).

Comment thread CHANGELOG.md Outdated
…stid-separators

Standardize wallet test ID separators
@EdgeClaws
EdgeClaws force-pushed the jared/cherry-pick-6172-6203-to-staging branch from 9ba4fe7 to bfa1f04 Compare September 8, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants