Skip to content

Fix compile on libretiny due to round macro conflict#214

Merged
mathieucarbou merged 2 commits into
ESP32Async:mainfrom
bdraco:libretiny_Fix
Jul 1, 2025
Merged

Fix compile on libretiny due to round macro conflict#214
mathieucarbou merged 2 commits into
ESP32Async:mainfrom
bdraco:libretiny_Fix

Conversation

@bdraco

@bdraco bdraco commented Jul 1, 2025

Copy link
Copy Markdown

chrono:360:47: error: macro "round" passed 2 arguments, but takes just 1

Comment thread src/AsyncEventSource.h
@bdraco

bdraco commented Jul 1, 2025

Copy link
Copy Markdown
Author

rechecked compile success with |-- ESPAsyncWebServer @ 3.7.9+sha.c9b70bd

@mathieucarbou mathieucarbou added Type: Bug Something isn't working Platform: Libretiny labels Jul 1, 2025
@bdraco

bdraco commented Jul 1, 2025

Copy link
Copy Markdown
Author

Thanks. If you could do a release, I'll bump the version in ESPHome

@mathieucarbou mathieucarbou merged commit 029b057 into ESP32Async:main Jul 1, 2025
35 checks passed
@lamauny

lamauny commented Jul 10, 2025

Copy link
Copy Markdown

Hi, I'm encountering this issue using ESPHome last beta 2025.7.0b1: when does a release can be integrated to esphome ?

@mathieucarbou

Copy link
Copy Markdown
Member

Hi, I'm encountering this issue using ESPHome last beta 2025.7.0b1: when does a release can be integrated to esphome ?

waiting for @me-no-dev to review pending PR...

@lamauny

lamauny commented Jul 12, 2025

Copy link
Copy Markdown

@bdraco : just wondering why ESPHome CI tests for 2025.7.0b1 were successful whereas compilation obviously fails with LibreTiny ?

@bdraco bdraco deleted the libretiny_Fix branch July 14, 2025 01:12
@bdraco

bdraco commented Jul 14, 2025

Copy link
Copy Markdown
Author

We didn't have a test for this case -- esphome/issues#7230 proposes to add one via esphome/esphome#9457

@bdraco

bdraco commented Jul 14, 2025

Copy link
Copy Markdown
Author

I started work on getting ESPHome's fork back up to date in case a release isn't possible before the ESPHome release.

esphome#50

@lamauny

lamauny commented Jul 16, 2025

Copy link
Copy Markdown

ESPHome 2025.7.0.b5 solves this issue, however the ASyncTCP compilation still fails with LibreTiny:

.piolibdeps/test/AsyncTCP/src/AsyncTCP.cpp: In function 'void _send_async_event(lwip_tcp_event_packet_t*)':
.piolibdeps/test/AsyncTCP/src/AsyncTCP.cpp:202:3: error: 'xTaskNotifyGive' was not declared in this scope
Compiling .pioenvs/test/lib01c/ESPAsyncWebServer/AsyncJson.cpp.o
*** [.pioenvs/test/lib562/AsyncTCP/AsyncTCP.cpp.o] Error 1
In file included from src/esphome/core/event_pool.h:8,
                 from src/esphome.h:56,
                 from src/main.cpp:3:
src/esphome/core/lock_free_queue.h: In member function 'bool esphome::NotifyingLockFreeQueue<T, SIZE>::push(T*)':
src/esphome/core/lock_free_queue.h:133:7: error: there are no arguments to 'xTaskNotifyGive' that depend on a template parameter, so a declaration of 'xTaskNotifyGive' must be available [-fpermissive]
  133 |       xTaskNotifyGive(task_to_notify_);
      |       ^~~~~~~~~~~~~~~
src/esphome/core/lock_free_queue.h:133:7: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated)

Maybe because of a new GCC version ?
Here is my basic test yaml : test.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants