Skip to content

Change quadratic code solver - #4255

Open
ekluzek wants to merge 12 commits into
ESCOMP:b4b-devfrom
ekluzek:change_code_recipes
Open

ekluzek wants to merge 12 commits into
ESCOMP:b4b-devfrom
ekluzek:change_code_recipes

Conversation

@ekluzek

@ekluzek ekluzek commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Description of changes

Update the quadratic solver to make sure it's distinguished from copyrighted code. Remove the duplicated version in LUNA.

Specific notes

Contributors other than yourself, if any:

CTSM issues resolved or otherwise addressed, if any:

If answers are expected to change, describe (delete this line otherwise): No

Any user interface changes (namelist or namelist defaults changes)? No

Testing planned or performed, if any:

  • aux_clm Derecho
  • aux_clm Izumi

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s):
  • This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: a
  • I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe:
  • This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?: a

@ekluzek
ekluzek requested a review from slevis-lmwg October 10, 2026 07:20
@ekluzek ekluzek self-assigned this Oct 10, 2026
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability b4b bit-for-bit labels Oct 10, 2026
@ekluzek ekluzek linked an issue Oct 10, 2026 that may be closed by this pull request
@ekluzek
ekluzek changed the base branch from master to b4b-dev October 10, 2026 07:22
Comment thread src/biogeophys/PhotosynthesisMod.F90

@slevis-lmwg slevis-lmwg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions and otherwise I'm approving. I hope that the legal issues here will not hinder the progress of science.

Comment thread src/utils/quadraticMod.F90 Outdated
Comment thread src/utils/quadraticMod.F90 Outdated
Comment thread src/utils/test/quadratic_test/test_quadratic.pf
Comment thread src/biogeophys/TridiagonalMod.F90 Outdated
Comment thread src/biogeophys/TridiagonalMod.F90 Outdated
ekluzek and others added 6 commits October 12, 2026 13:48
Co-authored-by: Samuel Levis <slevis@ucar.edu>
Co-authored-by: Samuel Levis <slevis@ucar.edu>
I might revert this for going on master if it changes answers.

Co-authored-by: Samuel Levis <slevis@ucar.edu>
Co-authored-by: Samuel Levis <slevis@ucar.edu>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit enhancement new capability or improved behavior of existing capability

Projects

Status: In progress - master
Status: Done

Development

Successfully merging this pull request may close these issues.

Update and distinquish the quadratic solver

2 participants