Minor changes to FindHipoDeps to support Intel MLK BLAS library.#3082
Merged
Conversation
…, `-DBLA_VENDOR=Intel10_64lp_seq` Note, we currently define `blasint` as 32bit, so need to use `64lp` rather than `64ilp` (or update blasint to `int64_t`).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #3082 +/- ##
==========================================
- Coverage 73.04% 73.04% -0.01%
==========================================
Files 426 426
Lines 102324 102324
Branches 16459 16459
==========================================
- Hits 74747 74745 -2
- Misses 27301 27303 +2
Partials 276 276 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
LGTM! |
galabovaa
self-requested a review
June 25, 2026 18:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: we currently define
blasintas 32bit, so need to use64lprather than64ilp(or update blasint toint64_t).Build notes:
I tested this by installing Intel MKL via vcpkg:
intel-mkl. I modified theextern/vcpkg.jsonto replaceOpenBLASdependency. Sincex64-windows-staticis defined vcpkg installedIntel10_64ilp_seqon my machine.There were some issues with
find_package(MKL ...), so I needed to specifyMLK_LINKandMKL_THREADINGfor it to find the correct files. Since vcpkg installs64ilpby default, I needed to modifymycblas.hto changeblasintdefinition. Lastly, without specifyingRelease, thefind_package(...)found the debug lib files from vcpkg.It should be possible to configure MKL differently (e.g., not using vcpkg), just make sure the build flags match whatever you're trying to do.
Full parameters: