Repository navigation
fix: Get rid of console errors and warnings - #384
Merged
ajivanyandev merged 3 commits intoOct 6, 2026
Merged
ajivanyandev merged 3 commits into
ajivanyandev merged 3 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Generated paths do not normalize dotted theme color schemes to the hyphenated values used by application routes.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates metadata loading, theme selection rendering, iframe routing, and GitHub Pages route generation to eliminate browser warnings and routing errors.
Changes:
- Deduplicates concurrent metadata requests.
- Modernizes the theme selector and iframe URLs.
- Generates static pages for Angular routes on GitHub Pages.
| File | Description |
|---|---|
src/app/meta-repository.service.ts |
Caches in-flight metadata requests. |
src/app/layouts/header/header.component.ts |
Adds theme display formatting. |
src/app/layouts/header/header.component.html |
Reworks the selector field template. |
src/app/layouts/header/header.component.css |
Updates selector icon styling. |
src/app/iframe/iframe.component.ts |
Adds trailing slashes to iframe URLs. |
package.json |
Runs route-page generation after builds. |
generate-route-pages.js |
Generates static GitHub Pages route files. |
copyfile.js |
Removes the superseded 404-only script. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
GoodDayForSurf
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.