DataGrid: Fix horizontal touch scrolling on freespace row with rowDragging enabled (T1329643)#34116
Merged
Merged
Conversation
…gging enabled (T1329643)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a touch interaction regression in the internal Draggable implementation used by DataGrid row dragging, ensuring horizontal native scrolling isn’t blocked when a drag gesture is detected but an actual drag doesn’t start (T1329643).
Changes:
- Adjusts when
dragInProgressis set and adds logic to allow native scrolling by settinge._cancelPreventDefaultwhen no drag is active. - Refactors drag-move handling slightly (extracting
_moveDragElement) and stores the last move event for auto-scroll reprocessing. - Adds Jest coverage around
dragInProgressand preventDefault behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/m_draggable.ts | Updates drag state timing and prevents dxdrag from blocking native scrolling when no drag is in progress. |
| packages/devextreme/js/__internal/tests/draggable.test.ts | Adds Jest tests for dragInProgress and default-prevention behavior during drag gestures. |
anna-shakhova
previously approved these changes
Jun 25, 2026
Raushen
previously approved these changes
Jun 25, 2026
anna-shakhova
previously approved these changes
Jun 25, 2026
Raushen
approved these changes
Jun 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.