Use Angular 22 in demos#34038
Merged
GoodDayForSurf merged 98 commits intoJun 26, 2026
Merged
Conversation
…26_1_WIP_check_ng22 # Conflicts: # pnpm-lock.yaml
+ update lock
…26_1_WIP_check_ng22 # Conflicts: # apps/demos/package.json # pnpm-lock.yaml
…26_1_WIP_check_ng22 # Conflicts: # apps/demos/package.json # pnpm-lock.yaml
…26_1_WIP_check_ng22 # Conflicts: # pnpm-lock.yaml
…lt for compatibility with previous versions of NG
GoodDayForSurf
dismissed stale reviews from EugeniyKiyashko, bit-byte0, r-farkhutdinov, Alyar666, and marker-dao
via
5f416c2
GoodDayForSurf
requested review from
Alyar666,
EugeniyKiyashko,
bit-byte0,
marker-dao and
r-farkhutdinov
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 65 out of 69 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
apps/demos/Demos/Splitter/Overview/Angular/app/app.component.ts:25
- The
@Componentmetadata defineschangeDetectiontwice. The latter (OnPush) wins, so the newly addedEageroption is ignored and the object contains a duplicate key.
…26_1_use_ng22_in_demos # Conflicts: # pnpm-lock.yaml
ajivanyandev
approved these changes
Jun 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 65 out of 69 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
apps/demos/Demos/Splitter/Overview/Angular/app/app.component.ts:25
@Componentmetadata defineschangeDetectiontwice; in object literals the last property wins, soChangeDetectionStrategy.Eageris ignored and the earlier line is misleading. Keep a singlechangeDetectionvalue.
apps/demos/utils/demo-ts-loader.js:18if (ts === undefined)will throw aReferenceErrorif the globaltsvariable is not defined, so the intended custom error message will never be shown. Use atypeofcheck instead.
aleksei-semikozov
approved these changes
Jun 26, 2026
marker-dao
approved these changes
Jun 26, 2026
pharret31
approved these changes
Jun 26, 2026
Alyar666
approved these changes
Jun 26, 2026
bit-byte0
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.