Auto-activate php easy wins for profiling - #7469
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6cceb4d82
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - weblog_declaration: | ||
| laravel11x: missing_feature (profiling seems not to be activated) | ||
| php-fpm-8.5: missing_feature (profiling seems not to be activated) | ||
| symfony7x: missing_feature (profiling seems not to be activated) |
There was a problem hiding this comment.
For the php profiling easy wins, this added weblog_declaration is another missing_feature for the same three weblogs that are already skipped by the immediately preceding block, and the analogous test_process_tags_svc addition below is also behind an unconditional missing_feature. Manifest conditions accumulate rather than override, so laravel11x/php-fpm-8.5/symfony7x still produce skip declarations and the tests remain disabled; remove or narrow the existing skip entries instead.
Useful? React with 👍 / 👎.
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
a6cceb4 to
db452e4
Compare
new commit added, dismiss all previous approvals
db452e4 to
913c79f
Compare
new commit added, dismiss all previous approvals
913c79f to
55a1261
Compare
new commit added, dismiss all previous approvals
55a1261 to
8ddde04
Compare
new commit added, dismiss all previous approvals
8ddde04 to
726d9d8
Compare
new commit added, dismiss all previous approvals
726d9d8 to
ca5268c
Compare
new commit added, dismiss all previous approvals
ca5268c to
bee86d8
Compare
new commit added, dismiss all previous approvals
bee86d8 to
e408be9
Compare
new commit added, dismiss all previous approvals
e408be9 to
7a9be0e
Compare
new commit added, dismiss all previous approvals
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7a9be0e to
54637ff
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
phpowned byprofilingView nightly workflow run