Skip to content

Validate jira ticket reason for manifest declarations in the parser to improve error clarity - #7422

Merged
nccatoni merged 2 commits into
mainfrom
nccatoni/jira-valid-manifests
Aug 5, 2026
Merged

Validate jira ticket reason for manifest declarations in the parser to improve error clarity#7422
nccatoni merged 2 commits into
mainfrom
nccatoni/jira-valid-manifests

Conversation

@nccatoni

Copy link
Copy Markdown
Collaborator

Motivation

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@nccatoni
nccatoni marked this pull request as ready for review July 30, 2026 07:50
@nccatoni
nccatoni requested a review from a team as a code owner July 30, 2026 07:50
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/test_the_test/manifests/manifests_agent_edit/agent.yml            @DataDog/system-tests-core
tests/test_the_test/test_decorators.py                                  @DataDog/system-tests-core
tests/test_the_test/test_easy_win.py                                    @DataDog/system-tests-core
tests/test_the_test/test_manifest.py                                    @DataDog/system-tests-core
utils/_decorators.py                                                    @DataDog/system-tests-core
utils/manifest/__init__.py                                              @DataDog/system-tests-core
utils/manifest/_internal/__init__.py                                    @DataDog/system-tests-core
utils/manifest/_internal/declaration.py                                 @DataDog/system-tests-core

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 0 passed on retry View in Datadog

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1f0f268 | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 540cfb096a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread utils/manifest/_internal/declaration.py
Comment thread utils/manifest/_internal/declaration.py
@nccatoni
nccatoni merged commit 068dfe0 into main Aug 5, 2026
3504 of 3510 checks passed
@nccatoni
nccatoni deleted the nccatoni/jira-valid-manifests branch August 5, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant