Skip to content

Auto-activate php easy wins for asm-libraries - #6622

Open
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/asm-libraries/php
Open

Auto-activate php easy wins for asm-libraries#6622
dd-octo-sts[bot] wants to merge 1 commit into
mainfrom
easy-win/asm-libraries/php

Conversation

@dd-octo-sts

@dd-octo-sts dd-octo-sts Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Automated activation of easy-win tests for php owned by asm-libraries
View nightly workflow run

  • If you approve this PR please also merge it.
  • If the tests are failing it might be due to a change made since the last nightly system-tests run. You can close the PR, an updated one will be available tomorrow.
  • If you close the PR please also delete the branch

@dd-octo-sts
dd-octo-sts Bot requested review from a team as code owners March 27, 2026 17:50
@dd-octo-sts
dd-octo-sts Bot enabled auto-merge (squash) March 27, 2026 17:50
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea4abb75ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread manifests/php.yml Outdated
Comment on lines +685 to +689
'*': missing_feature
php-fpm-8.0: '>=1.17.0'
php-fpm-7.1: '>=1.17.0'
apache-mod-7.2-zts: '>=1.17.0'
apache-mod-7.4-zts: '>=1.17.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include php-fpm-8.5 in telemetry class activation map

Because weblog_declaration uses '*': missing_feature as a fallback, any omitted weblog stays skipped for the whole class. This block enumerates PHP weblogs for Test_TelemetryMetrics but omits php-fpm-8.5, so all telemetry tests remain missing_feature on that variant even though the newly added method-level rules also omit php-fpm-8.5 (which suggests it was intended to be activated there). Add php-fpm-8.5: '>=1.17.0' to this class-level map to avoid silently dropping the easy-win activation on that weblog.

Useful? React with 👍 / 👎.

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/asm-libraries/php branch from ea4abb7 to 63c3266 Compare August 5, 2026 07:31
@dd-prapprover-prod-77c48c

dd-prapprover-prod-77c48c Bot commented Aug 5, 2026

Copy link
Copy Markdown

PRApprover will approve and merge this PR, FAQ, #dx-source-code-management

🛠️ PRApproval Status

  • ✅ PR is eligible for auto-approval by rule system-tests-auto-activate-easy-wins - 2026-08-13T09:32:02Z
  • ⬜ CI tests passed
  • ⬜ Approved
  • Manual merge required: this rule does not auto-merge.

➡️ Current phase: CI tests failed. Please fix the failing tests and rerun the workflow, click Workflow Link -> Workflow Starter Link -> Start Workflow

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 5, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 30 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.0-zts 2   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Test run failed. Assertion error: Expected 'found_waf_metric' to be True but was False at tests/appsec/smoke_tests/utils.py:241.

🧪 2 Tests failed · 🎯 related to the job error above

🎯 tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecStandaloneAPMStandalone_Telemetry.test_telemetry_smoke[apache-mod-7.0-zts] from system_tests_suite   View in Datadog
assert False

self = <tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecStandaloneAPMStandalone_Telemetry object at 0x7fb1ebd0b740>

    def test_telemetry_smoke(self) -> None:
        telemetry_data = list(interfaces.agent.get_telemetry_data(flatten_message_batches=False))
    
        assert telemetry_data, "Agent should forward telemetry data from the library"
    
        found_metrics = False
...
🎯 ❄️ Known flaky: tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecAPMStandalone_Telemetry.test_telemetry_smoke[apache-mod-7.0-zts] from system_tests_suite   View in Datadog
assert False

self = <tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecAPMStandalone_Telemetry object at 0x7fc78c912fc0>

    def test_telemetry_smoke(self) -> None:
        telemetry_data = list(interfaces.agent.get_telemetry_data(flatten_message_batches=False))
    
        assert telemetry_data, "Agent should forward telemetry data from the library"
    
        found_metrics = False
...

Not introduced in this PR.

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.1 2   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. Test run failed. Assertion Error: assert False at tests/appsec/smoke_tests/utils.py:241.

🧪 2 Tests failed · 🎯 related to the job error above

🎯 tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecAPMStandalone_Telemetry.test_telemetry_smoke[apache-mod-7.1] from system_tests_suite   View in Datadog
assert False

self = <tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecAPMStandalone_Telemetry object at 0x7f26ea2497c0>

    def test_telemetry_smoke(self) -> None:
        telemetry_data = list(interfaces.agent.get_telemetry_data(flatten_message_batches=False))
    
        assert telemetry_data, "Agent should forward telemetry data from the library"
    
        found_metrics = False
...
🎯 ❄️ Known flaky: tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecStandaloneAPMStandalone_Telemetry.test_telemetry_smoke[apache-mod-7.1] from system_tests_suite   View in Datadog
assert False

self = <tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecStandaloneAPMStandalone_Telemetry object at 0x7f91efa12cc0>

    def test_telemetry_smoke(self) -> None:
        telemetry_data = list(interfaces.agent.get_telemetry_data(flatten_message_batches=False))
    
        assert telemetry_data, "Agent should forward telemetry data from the library"
    
        found_metrics = False
...

Not introduced in this PR.

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.1-zts 2   View in Datadog   GitHub Actions

🔧 Fix in code. This looks caused by changes in this PR. 1 failed test: AssertionError: assert False in test_telemetry_smoke at tests/appsec/smoke_tests/utils.py:241

🧪 1 Test failed · 🎯 related to the job error above

🎯 tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecStandaloneAPMStandalone_Telemetry.test_telemetry_smoke[apache-mod-7.1-zts] from system_tests_suite   View in Datadog
assert False

self = <tests.appsec.smoke_tests.test_apm_standalone.Test_AppSecStandaloneAPMStandalone_Telemetry object at 0x7f20884af920>

    def test_telemetry_smoke(self) -> None:
        telemetry_data = list(interfaces.agent.get_telemetry_data(flatten_message_batches=False))
    
        assert telemetry_data, "Agent should forward telemetry data from the library"
    
        found_metrics = False
...

View all 30 failed jobs.

📋 Copy prompt for your agent
CI on my pull request is failing. Help me find and fix the root cause of each failing job below — they were flagged as caused by changes in this PR, so focus on the diff. For each job, explain the failure and propose a fix.

Branch: easy-win/asm-libraries/php

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.0-zts 2
Commit: d8885d134d151c741baad482d1c8f18fdecfbd84
Error (code / test):
1 failed test. Assertion error: Expected 'found_waf_metric' to be True but was False at tests/appsec/smoke_tests/utils.py:241.
CI job: https://github.com/DataDog/system-tests/actions/runs/31686988429/job/94408209935

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.1 2
Commit: d8885d134d151c741baad482d1c8f18fdecfbd84
Error (code / test):
1 failed test. Assertion Error: assert False at tests/appsec/smoke_tests/utils.py:241.
CI job: https://github.com/DataDog/system-tests/actions/runs/31686988429/job/94408208747

Testing the test | System Tests (php, dev) / End-to-end #2 / apache-mod-7.1-zts 2
Commit: d8885d134d151c741baad482d1c8f18fdecfbd84
Error (code / test):
1 failed test: AssertionError: assert False in test_telemetry_smoke at tests/appsec/smoke_tests/utils.py:241
CI job: https://github.com/DataDog/system-tests/actions/runs/31686988429/job/94408208880

Plus 22 more failing jobs not shown here.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 35dfe66 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/asm-libraries/php branch 8 times, most recently from ba63aa5 to f87ce5e Compare August 13, 2026 07:20
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dd-octo-sts
dd-octo-sts Bot force-pushed the easy-win/asm-libraries/php branch from f87ce5e to 35dfe66 Compare August 13, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants