refactor(datadog-ffe)!: rename crate so it can be published to crates.io - #2285
Open
hoolioh wants to merge 14 commits into
Open
refactor(datadog-ffe)!: rename crate so it can be published to crates.io#2285hoolioh wants to merge 14 commits into
hoolioh wants to merge 14 commits into
Conversation
Contributor
Clippy Allow Annotation ReportTracked Clippy
By file and crateBy file
By crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. Panic-inducing macros in particular should be avoided. In the future, this report may become a PR-blocking quality gate. |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: e9949e8 | Docs | Datadog PR Page | Give us feedback! |
hoolioh
changed the title
BenchmarksComparisonBenchmark execution time: 2026-07-31 08:44:16 Comparing candidate commit e9949e8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 140 metrics, 0 unstable metrics.
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
hoolioh
force-pushed
the
julio/publish-ffe
branch
from
July 29, 2026 08:20
b5b9efa to
3a48c64
Compare
hoolioh
marked this pull request as ready for review
July 29, 2026 10:02
hoolioh
requested review from
pavlokhrebto and
typotter
and removed request for
a team
July 29, 2026 10:02
Aaalibaba42
approved these changes
Jul 29, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f05567da39
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
hoolioh
force-pushed
the
julio/publish-ffe
branch
from
July 29, 2026 13:16
f05567d to
560c605
Compare
hoolioh
force-pushed
the
julio/publish-ffe
branch
from
July 29, 2026 13:31
560c605 to
f8b548b
Compare
Contributor
📚 Documentation Check Results📦
|
Contributor
🔒 Cargo Deny Results📦
|
dd-oleksii
self-requested a review
July 30, 2026 11:47
dd-oleksii
reviewed
Jul 30, 2026
| name = "datadog-ffe" | ||
| version = "1.0.0" | ||
| name = "libdd-ffe" | ||
| version = "0.1.0" |
Member
There was a problem hiding this comment.
major: any reason this is downgraded to sub 1?
Contributor
Author
There was a problem hiding this comment.
It's to avoid that the release system will publish a 2.0.0 version. The release system works on the assumption that every crate on the workspace stays in beta until it's published because it doesn't track which crates are published and which aren't so if I leave the 1.0.0 the system will bump the major and a 2.0.0 version will appear as a the first release in crates.io.
It's something we could improve in the future though
Member
There was a problem hiding this comment.
Then we need to decrease libdd-ffe-ffi crate version as well?
Contributor
Author
There was a problem hiding this comment.
It's not needed, at the moment, we're not publishing the ffi crates since the ffi library is consumed via the released artifacts or by tag reference to libdd-profiling-ffi crate (which is the one that manages the inclusion of the rest of the crates).
In the future if we publish the ffi crates we will need to do it but we're in thinking about how to rearchitecture the whole thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the proper changes to publish FFE crate, for that the crate name has to be renamed in order to adhere to the repo publishing policies and dependants references updated.
Motivation
Allow downstream projects to use independent versions.