Skip to content

[DSEM-999] Add deprecated warning banner to ddsql_schema dataset pages #38514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
irenegaunab merged 7 commits into from
Jul 29, 2026
Merged

[DSEM-999] Add deprecated warning banner to ddsql_schema dataset pages #38514

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25c706a
Add deprecated warning banner to ddsql_schema dataset pages
irenegaunab Jul 28, 2026
c44f9cb
TEST ONLY: add deprecated dataset page to verify warning banner - rem…
irenegaunab Jul 28, 2026
7b6869a
Remove temporary test page used to verify deprecated banner
irenegaunab Jul 28, 2026
d4681c0
Simplify deprecated banner text to avoid overly specific claim about …
irenegaunab Jul 28, 2026
8869ea8
Update deprecated banner: 'may return no data'
irenegaunab Jul 28, 2026
ade9dc9
Add temporary test file for deprecated banner screenshot
irenegaunab Jul 29, 2026
4d4c44c
Remove temporary test file for deprecated banner
irenegaunab Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions layouts/ddsql_schema/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ <h1 id="pagetitle">{{ .Title }}</h1>
{{ partial "site_support_banner/site_support_banner.html" . }}

<div class="ddsql-schema-single">
{{ if eq .Params.status "deprecated" }}

@petitcl petitcl Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the place where we filter out non stable datasets and it's here. This logic should probably be updated to be "status == stable | deprecated" (ie allowlist of known supported statuses in case we want to add more statuses in the future).

<div class="alert alert-warning">
<strong>Deprecated</strong>: This table is deprecated and may return no data.
Comment thread
irenegaunab marked this conversation as resolved.
</div>
{{ end }}

<p>{{ .Params.summary | markdownify }}</p>

{{ highlight .Params.id "" }}
Expand Down
Loading