Fix JSON span event encoding in v1 payloads. - #12107
Fix JSON span event encoding in v1 payloads.#12107gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7d2c4af | Docs | Datadog PR Page | Give us feedback! |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
There was a problem hiding this comment.
More details
The JSON span-event path preserves the existing v1 filtering and encoding behavior while converting the OpenTelemetry tag into native span_events; malformed or non-array input falls back to an empty array without leaking the tag into attributes. Local Gradle execution was blocked by the unavailable Java 25 toolchain.
🤖 Datadog Autotest · Commit 6680c2b · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6680c2bb18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # dd-trace-core/src/test/java/datadog/trace/core/DDSpanSerializationTest.java
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
90e912b
into
master
What Does This Do
Parses the existing
eventsJSON tag inTraceMapperV1and encodes span events into the native v1 MessagePackspan_eventsfield.Motivation
OpenTelemetry span events are stored as JSON, while
TraceMapperV1only handled pre-parsedListvalues. This caused v1 payloads to contain an emptyspan_eventsarray.Additional Notes
This is a focused compatibility fix.