planner: adjust "upper" bottom-anchored widget positions (hollow constructions, stair type, engraved slabs, empty cages, weapon count)#5852
Open
ChrisJohnsen wants to merge 1 commit into
Conversation
When, in 39cc838, the main_panel gained an extra UI line to accommodate the "queue order" hotkey label, the other bottom-anchored widgets in the upper portion of the main_panel were not adjusted. Several of these (conditional) widgets end up being drawn "under" the divider. They are still present (their hotkeys still work (and they are still clickable!), but they are not visible). The inadvertently hidden widgets are: - the hotkeys (and weapon count) for weapon traps - the hollow toggle for constructions (walls, floors, etc.) - the engraved-only toggle for slabs - the empty-only toggle for (non-trap) cages The other bottom-anchored "upper" widgets are: - the slider for weapon traps - the up/down/up-down/auto selectors for single- and multi-level stairs Move all these widgets up one UI line to unhide the "hidden" widgets and preserve their relative vertical layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in Discord, the "Hollow area" UI element in buildingplan's planneroverlay disappeared in 53.15-r2.
It is still there (its hotkey still works, and it is still actually clickable—if you already knew its hotkey and/or where to blind-click), but the divider is being drawn over it.
When 39cc838 added an extra UI row for the "queue order" button, the bottom-anchored UI elements in the upper area of the main_panel were not adjusted to account for the extra line.
The "stair type", "engraved slabs only", "empty cages only", and "weapon count" planner UI elements (all similarly conditional) are affected in the same way.
The commit bumps all the bottom-anchored UI elements in the "upper" portion of the planner overlay up by one UI row.