Refactor button widgets; add widgets.RadioButton#5781
Conversation
Bumber64
changed the title
widgets.ToggleButtonwidgets.RadioButton
* Update widgets.lua - RadioButton * Update and rename toggle_button.lua to radio_button.lua * Update help_button.lua * Update configure_button.lua - Replace GraphicButton * Delete library/lua/gui/widgets/buttons/graphic_button.lua * Update Lua API.rst - Add RadioButton; HelpButton now subclass
* Update radio_button.lua * Update configure_button.lua * Update help_button.lua
SilasD
left a comment
SilasD
left a comment
There was a problem hiding this comment.
I'm okay with this, I guess.
RadioButton looks a little bit half-baked, but it's in a usable state.
|
For the record: Pure code-quality changes that don't have user-facing effects do not require a changelog. |
|
Did we confirm that the IIRC, it's used for a Lua language server, which I don't use. |
It all looked good. the when I get my local fork of vallode's LuaLS whipped into better shape I'll spend some time with all of these classes' annotations. |
3 participants
Refactor
widgets.ConfigureButtonand makewidgets.HelpButtona subclass of it. Addwidgets.RadioButton, which looks and functions like the buttons in thegui/control-panellist.I don't understand the
---@fieldstuff very well, so I based it on examples as best I could. Needs to be verified.