Repository navigation
Conversation
…tion-copy resolution Fully qualify the type inline as `\Closure` in all three docblocks. Because the qualification lives in the docblock text itself, it survives being copied verbatim into any consumer's generated actor class — resolving correctly regardless of that file's namespace or its own imports.
JeroenBoesten
approved these changes
Aug 26, 2026
|
Great fix! Unfortunately the
|
…es in public docblocks Docblocks of public module methods are copied verbatim into consumers' generated actor classes, where aliased or unqualified imports (EloquentModel, EloquentCollection, RuntimeException, Authenticatable) do not resolve. Fully qualify them inline, and drop the now-unused EloquentCollection import.
Author
|
Thanks! Fully qualified EloquentModel, EloquentCollection and RuntimeException in the public InteractsWithEloquent docblocks, and also Authenticatable in amLoggedAs, which had the same issue. The remaining unqualified names are only on hook/protected/private methods, which aren't copied into the actor. |
TavoNiievez
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully qualify the type inline as
\Closurein all three docblocks. Because the qualification lives in the docblock text itself, it survives being copied verbatim into any consumer's generated actor class — resolving correctly regardless of that file's namespace or its own imports.