London | 26-ITP-Sep | Abdennour Hachemi | Sprint 3 | Coursework3 by AbdennourHachemi · Pull Request #1591 · CodeYourFuture/Module-JavaScript-Fundamentals

AbdennourHachemi · 2026-09-25T11:29:21Z

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053.

netlify · 2026-09-25T11:29:28Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`5698bf5`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abde4a9f17d78000858431b
😎 Deploy Preview	https://deploy-preview-1591--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

abdishakoor-dev

3-to-pounds.js works well. You tried many inputs, including "0P" and a negative amount.

Four things before I can mark this Complete:

1-key-errors/1.js has no changes yet. Please do this exercise too: predict, explain and fix.
Your fixed code is in comments, so it never runs. See my comment on 1-key-errors/0.js line 15. The same is true in 1-key-errors/2.js and in 2-mandatory-debug/1.js and 2.js. In 2-mandatory-debug/0.js both versions are in comments, so the file prints nothing.
time-format.js b): see my comment on line 32.
1-bmi.js: see my comment on line 19.

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-29T11:01:42Z

-// =============> write your new code here
+// =============> write your explanation here SyntaxError: Identifier 'str' has already been declared =>  line 10 varibale str should not be declared again.
+// =============> write your new code
+// function capitalise(str) {


Your new code on lines 15 to 19 is in comments. So it never runs. The original code on lines 8 to 11 still runs. Run this file with node. What do you see? The broken code should stop running, and your fix should run. Can you swap them?

Fixed now. Your fix runs, and the original is in comments. Good.

abdishakoor-dev · 2026-09-29T11:01:42Z

-// b) What is the value assigned to num when pad is called for the first time?
-// =============> write your answer here
+// b) What is the value assigned to num when pad is called for the first time?:
+// =============> write your answer here: ***Answer*** : The value assigned to num =61.


Line 16 calls pad three times. Which call is first? When the input is 61, what is totalHours? Your log on line 6 prints 00 first. Does that match 61?

b) on line 31 still says 61.

Look at line 15. The first call is pad(totalHours). So on the first call, num is the value of totalHours, not 61.

61 seconds is 1 minute and 1 second. How many whole hours is that? Your answer to c) says the first call returns "00". Which number gives "00"?

Nearly. On the first call, num is the number 0. "00" is what pad gives back, which is your answer to c). The value going in is a number, and the value coming out is a string.

Please change b) on line 31 to 0.

0 is right now.

abdishakoor-dev · 2026-09-29T11:01:42Z


 function calculateBMI(weight, height) {
  // return the BMI of someone based off their weight and height
+  return weight / (height * height);


Line 15 says the function should return a string to 1 decimal place. Your toFixed(1) is on line 22, outside the function. What does calculateBMI(70, 1.73) return on its own?

It returns the string "23.4" now. Good.

abdishakoor-dev

Most of the list is done, thanks. The key-errors files and 2-mandatory-debug/0.js now run your fix, and calculateBMI returns a string.

Three things before I can mark this Complete:

2-mandatory-debug/1.js and 2.js: the fix is still in comments. See my comment on 1.js line 15.
time-format.js b): see my reply on line 31.
1-key-errors/1.js fails Prettier now. Lines 21 to 28 have extra spaces at the start. Right click in the file, choose Format Document, and pick Prettier if VS Code asks. To format every time you save, follow the steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-29T17:16:01Z

 // Finally, correct the code to fix the problem
 //  =============> write your new code here
+
+// function sum(a, b) {


Your new code on lines 15 to 17 is still in comments, so it never runs. The original code on lines 4 to 9 still runs. 2.js is the same: lines 27 to 32 are in comments, and lines 6 to 14 still run.

Please do what you did in 0.js: put the original code in comments, and take your new code out of them.

To check, right click the file in VS Code's file list and choose Open in Integrated Terminal. Then run node 1.js. It should print The sum of 10 and 32 is 42. For node 2.js, the last digits should be 2, 5 and 6.

Both files run your fix now. Good.

Prettier still flags 1.js: there is no empty line at the end of the file. Right click in the file, choose Format Document, save and push. To have Prettier do this every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

1.js passes Prettier now. Good.

abdishakoor-dev

Nearly there. Every file runs your fix now, and most of the list from last time is done.

Three things before I can mark this Complete:

2-mandatory-debug/2.js line 6 has an unused variable. See my comment there.
time-format.js b): see my reply on line 31.
2-mandatory-debug/1.js fails Prettier. See my reply on line 15.

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-09-30T08:17:18Z

-// =============> Write your prediction here
+// =============> Write your prediction here: This code will throw an error because the function getLastDigit does not take any parameters but we are passing a parameter to it in the console.log statements.

 const num = 103;


const num = 103; on line 6 is not used any more. Your function on line 27 has its own num parameter, so it never reads this one.

You said this yourself on line 35:

The first declaration of num as constent should be removed

But the line is still there. The CYF style guide says the same thing. You ticked it in your PR checklist ("My changes follow the style guide"). Under "Don't leave unused variables" it says:

You should remove any variables that are unused. This is because if you (or someone else) is reading your code, it can be confusing if you see a variable and then find out later that it isn't used. It could make you think that there's a bug, because the variable must have been put there for a reason!

https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/#dont-leave-unused-variables

Please delete line 6. Then run node 2.js again to check it still prints 2, 5 and 6.

It is in comments now, with the rest of the original code. node 2.js still prints 2, 5 and 6. Good.

abdishakoor-dev

Everything on the list is done. Marking this Complete.

Some things to watch for in the next sprint:

Run every file with node before you push. In this PR, your fixed code was in comments at first, so it never ran. If you run the file, you see this at once.
Remove what you don't use. If your new code does not need a variable, delete it.
Turn on format on save. Then Prettier formats each file for you. Right now time-format.js line 2 has no ; at the end, so Prettier flags it. Here are the steps: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

AbdennourHachemi added 10 commits September 25, 2026 12:19

solving exercise 0.js

00fdc77

solving exercise 2.js

567077e

solving 0.js

c91ef99

solving exercise 2-mandatory-debug 1.js

0afe2a9

solving exercise 2-mandatory-debug 2.js

292e899

solving exercise 3-mandatory-implement 1-bmi.js

c7c8f3a

solving the 2 3-mandatory-implements exercises

a239738

solve exercise 3-t-pounds.js

63cc7a9

Add time format functionality

c1fab78

solving format-time

ca30eb5

This comment has been minimized.

Sign in to view

AbdennourHachemi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 25, 2026

abdishakoor-dev reviewed Sep 29, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 29, 2026

AbdennourHachemi added 6 commits September 29, 2026 16:47

solving exercise 0.1

142dcbd

uncommingting correct code to be able to run

5a1f129

fixing exercise 2.js

f95f159

fixing exercise 0.1 2-mandatory-debug

f598953

fixing exercise 1-bmi.js

f4b5d6a

removing unnecessary console.log in line 6

cf05ff4

AbdennourHachemi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 29, 2026

abdishakoor-dev reviewed Sep 29, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 29, 2026

AbdennourHachemi added 2 commits September 29, 2026 21:50

uncomment solution for exercies 1.js

7947510

uncomment solution for exercies 2.js

b503934

AbdennourHachemi added 2 commits September 29, 2026 22:01

correct num value

92e3132

fix formatting to exercise 1.js

514bece

AbdennourHachemi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 29, 2026

abdishakoor-dev reviewed Sep 30, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 30, 2026

AbdennourHachemi added 3 commits October 1, 2026 05:32

removing unused variable

760800c

correct the answer for vlue assigned to num

a1cc998

fix 1.js formmatting issue

5698bf5

AbdennourHachemi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 1, 2026

abdishakoor-dev reviewed Oct 1, 2026

View reviewed changes

abdishakoor-dev added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 1, 2026

Uh oh!

Conversation

AbdennourHachemi commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Uh oh!

netlify Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AbdennourHachemi commented Sep 25, 2026 •

edited

Loading

netlify Bot commented Sep 25, 2026 •

edited

Loading