221 add validation to patch#227
Merged
Merged
Conversation
tsudhakar87
approved these changes
Jun 9, 2026
tsudhakar87
left a comment
tsudhakar87
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Just one question
nourshoreibah
requested changes
Jun 15, 2026
nourshoreibah
left a comment
nourshoreibah
left a comment
Collaborator
There was a problem hiding this comment.
Mainly one comment about required fields!
| let profileImage = body.profileImage as string | undefined; | ||
| const updates: { email?: string; name?: string; is_admin?: boolean; profile_image?: string } = {}; | ||
|
|
||
| const emailResult = UserValidationUtils.validateEmail(body.email); |
Collaborator
There was a problem hiding this comment.
Very much a nit but I wonder if we should just throw the whole body into the validation utils and let it handle all these conditionals 👀 I don't feel super strongly about this just an idea
nourshoreibah
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#221
Closes #221
📝 Description
Briefly list the changes made to the code:
✔️ Verification
Added tests
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!