Bump ClickHouse.Driver to 1.4.0-rc1 - #65
Draft
alex-clickhouse wants to merge 1 commit into
Draft
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
ClickHouse.Driverfrom1.3.0to1.4.0-rc1so we can validate the release candidate against this provider before 1.4.0 ships.Change
Three pins, kept in lockstep so the provider and both test projects resolve the same driver (a partial bump would risk an NU1605 downgrade):
src/EFCore.ClickHouse/EFCore.ClickHouse.csprojtest/EFCore.ClickHouse.Tests/EFCore.ClickHouse.Tests.csprojtest/EFCore.ClickHouse.FunctionalTests/EFCore.ClickHouse.FunctionalTests.csprojWhy this needs a CI run
1.4.0 carries wire-level breaking changes that the provider exercises on every query and insert:
ZstdCompressorrather thanGZipCompressor.ClickHouseDataReaderwith no current row now throwsInvalidOperationException— i.e. before the firstRead()or afterRead()returnsfalse. This is the one most likely to surface in provider-level materialization code.GetSchemaTable()now reportsNumericScaleforDateTime64(N)/Time64(N), andGetSchema("Columns", ...)composes itsWHEREclause differently — both touch provider metadata paths.Local verification
Built and tested against the RC before opening:
dotnet build -c Release— 0 errors (327 warnings, all pre-existing).dotnet test -c Release— 661 passed (EFCore.ClickHouse.Tests) and 323 passed / 4 skipped (EFCore.ClickHouse.FunctionalTests), 0 failed, against a real ClickHouse 25.10 server.ClickHouse.Driver/1.4.0-rc1is what actually resolved and shipped into the test output, not a silent fallback.Notably the reader-materialization and schema paths came through clean, which is where I'd have expected the breaking changes to bite.
Notes
1.4.0once it ships, then mark ready.AGENTS.mdI kept this to the version pins only — no unrelated churn. NoCHANGELOG.md/RELEASENOTES.mdentry, since an RC bump isn't a shipped behavior change; happy to add one when the final 1.4.0 bump lands.Co-Authored-By: Claude Opus 5 noreply@anthropic.com