Repository navigation
test: tighten listener, route-table and integration assertions (#55) - #73
Merged
Merged
Conversation
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #55 (Task 5 of the plan: the test-quality items). Tests only; no product code changes except a type-only tightening of the TS flag lists.
What changes
go/main_test.go):TestLockReleasedOnSIGKILLregisterst.Cleanupto kill and reap its child right aftercmd.Start(), so a failing assertion no longer leaks the process; the manual kill/wait pairs are gone.<path> is in use by another instance (lock <path>.lock held), as Rust does, instead of a substring.VALUE_FLAGSandBOOL_FLAGSareObject.freeze([...] as const), andvalidateFlagstakesreadonly string[]. No behaviour change.deploy/test.sh): a newcheck_deniedhelper passes only on a 403 whose body contains the proxy's deny message. All 28 checks expecting 403 use it, so a 403 from the daemon, or a different proxy deny, can no longer pass. Each request helper truncates the body file first, so a check can't pass on the previous body. The absolute-form check accepts either proxy message (Go and Rust deny it asexec is not allowed, TS asempty path segment not allowed). A mislabelled check (PATCH /containers/test, which sends POST) is relabelledPOST /containers/test -> 403 (no action segment).Review notes
test:commits). Simulated squash:bump=patch tag=v0.3.6.validation failed:as in Go and TS; the checks match the gate's own message, which all three share. Not changed here.Verification
make test-all: Go 109, Rust147 passed, TS164 tests, 0 fail, 1 skipped(unchanged).make lint-allpasses.ALL 45 TESTS PASSED./buildcheck at the wrong message fails it:FAIL: POST /build -> 403 (expected 403 with "commit is not allowed", got 403: build is not allowed). Reverted.Type of change
Implementation(s) changed
Testing
make test-all)Checklist