Skip to content

Add history to 2D ops#2053

Merged
adam-urbanczyk merged 7 commits into
masterfrom
adam-history-tweaks
Jun 26, 2026
Merged

Add history to 2D ops#2053
adam-urbanczyk merged 7 commits into
masterfrom
adam-history-tweaks

Conversation

@adam-urbanczyk

@adam-urbanczyk adam-urbanczyk commented Jun 22, 2026

Copy link
Copy Markdown
Member

Add history support to 2D ops.

@adam-urbanczyk adam-urbanczyk marked this pull request as draft June 22, 2026 06:15
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.76%. Comparing base (d6507b6) to head (b3a1d21).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2053   +/-   ##
=======================================
  Coverage   95.75%   95.76%           
=======================================
  Files          30       30           
  Lines        9358     9376   +18     
  Branches     1391     1395    +4     
=======================================
+ Hits         8961     8979   +18     
  Misses        242      242           
  Partials      155      155           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adam-urbanczyk adam-urbanczyk marked this pull request as ready for review June 23, 2026 20:52
@adam-urbanczyk adam-urbanczyk requested review from jmwright and lorenzncode and removed request for lorenzncode June 23, 2026 20:52

@jmwright jmwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread cadquery/occ_impl/shapes.py Outdated
Co-authored-by: Jeremy Wright <wrightjmf@gmail.com>
Comment thread cadquery/occ_impl/shapes.py
Comment thread cadquery/occ_impl/shapes.py Outdated

@lorenzncode lorenzncode left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No remaining issues found other than the prism comment mismatch line 7774.

Comment thread cadquery/occ_impl/shapes.py Outdated
Comment thread cadquery/occ_impl/shapes.py Outdated
@adam-urbanczyk adam-urbanczyk merged commit 09773f4 into master Jun 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants