Skip to content

ci: gate cacti.pot updates on i18n diff instead of regenerating #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheWitness merged 2 commits into from
Oct 5, 2026
Merged

ci: gate cacti.pot updates on i18n diff instead of regenerating #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a9f4d
ci: gate cacti.pot updates on i18n diff instead of regenerating
TheWitness Oct 5, 2026
080e064
ci: compare i18n strings via tokenizer instead of diff lines
TheWitness Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions .github/workflows/plugin-ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,13 @@ jobs:
find . -path './vendor' -prune -o -type f -name '*.php' -print0 | xargs -0 -r -n1 php -l

- name: Verify translation template is up to date
if: github.event_name == 'pull_request'
Comment thread
TheWitness marked this conversation as resolved.
env:
BASE_REF: ${{ github.event.pull_request.base.sha }}
run: |
cd ${{ github.workspace }}/cacti/plugins/reportit
sudo chmod +x locales/build_gettext.sh
sudo ./locales/build_gettext.sh
grep -v '^"POT-Creation-Date:' locales/po/cacti.pot > /tmp/cacti.pot.new
git checkout -- locales/
grep -v '^"POT-Creation-Date:' locales/po/cacti.pot > /tmp/cacti.pot.old
if ! cmp -s /tmp/cacti.pot.old /tmp/cacti.pot.new; then
echo "locales/po/cacti.pot is out of date. Run locales/build_gettext.sh and commit the updated locales/po/cacti.pot."
diff -u /tmp/cacti.pot.old /tmp/cacti.pot.new || true
exit 1
fi
git config --global --add safe.directory ${{ github.workspace }}/cacti/plugins/reportit
php tests/bin/check-i18n-pot.php "$BASE_REF"

- name: Set expected Cacti version for unit tests
run: echo -n "${{ env.CACTI }}" | sudo tee ${{ github.workspace }}/cacti/plugins/reportit/tests/.cacti-version > /dev/null
Expand Down
Loading
Loading