Skip to content

INFO: set compat to 1.2.32 - #148

Closed
TheWitness wants to merge 1 commit into
developfrom
chore/compat-1.2.32
Closed

TheWitness wants to merge 1 commit into
developfrom
chore/compat-1.2.32

Conversation

@TheWitness

Copy link
Copy Markdown
Member

Sets the plugin's compat (minimum supported Cacti version) in the INFO file to 1.2.32.

Note: this plugin previously declared compat = 1.3.0; set to 1.2.32 per the fleet-wide standardization. Revert if it truly requires a newer Cacti.

INFO-only change; no code changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new minimum conflicts with the stated end of Cacti 1.2.x support, and CI does not test that version.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

This PR lowers ReportIt’s advertised minimum Cacti version to align with the fleet-wide standard.

Changes:

  • Changes compat from 1.3.0 to 1.2.32; no code changes.
File Description
INFO Lowers the declared minimum Cacti version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread INFO
email = reportit@outlook.com
homepage = https://github.com/Cacti/plugin_reportit
compat = 1.3.0
compat = 1.2.32
@TheWitness

Copy link
Copy Markdown
Member Author

This should be >=1.3

@TheWitness TheWitness closed this Sep 30, 2026
@TheWitness

Copy link
Copy Markdown
Member Author

Closing this compat change. Following developer feedback, plugins that genuinely require Cacti 1.3+ should keep their 1.3+ floor rather than being lowered. reportit needs 1.3.0, so the original value stands and this PR (which lowered it to 1.2.32) is being closed without merging. develop remains at 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants