Monitor: redesign status legend as theme-appropriate colour chips

[TheWitness]

Description

Redesigns the Monitor status legend to match the thold and syslog legends: instead of the old fixed-position bar whose cells reused the subtle device-tile tints, the legend now renders as an evenly sized, wrapping flex row of rounded, solid-colour chips with white text.

• includes/controller.php now emits <div class='monitorLegend'> / <div class='monitorLegendItem …Full'> instead of the old .monitor_legend / .monitor_legend_cell markup.
• css/monitor.css carries the chip layout and the standard solid palette, scoped under .monitorLegend .device…Full so the device tiles keep their existing tints — only the legend chips get solid colours (same technique thold uses).
• Colours are semantic and consistent across every theme (up = green, down = red, recovering = amber, triggered = orange, acked/muted = purple/dark-red, warning = olive, alert = magenta, unknown = grey, no-availability-check = blue).
• css/deepness.css overrides the Up chip to emerald (#1f9f6e) to harmonise with the Deepness palette, mirroring what the thold Deepness theme does.
• Removed the now-dead per-theme .monitor_legend overrides from every theme stylesheet. Note: midwinter previously hid the legend entirely (display:none); it now shows the chip legend like the other themes.

All themes are in scope (classic, modern, paw, dark, midwinter, sunrise, paper-plane, and deepness).

Related Issue

Follows the same legend-chip treatment previously applied to thold and syslog.

Motivation and Context

A legend is a colour key, so its swatches should be solid and legible on every theme rather than inheriting the faint tile tints (which were hard to read, especially on dark themes). This brings Monitor's legend in line with the thold and syslog plugins for a consistent look across the Cacti plugin family.

How Has This Been Tested?

• php -l clean on includes/controller.php.
• Every edited stylesheet is brace-balanced (open == close).
• Confirmed no stale .monitor_legend / .monitor_legend_cell CSS-class references remain (the surviving monitor_legend references are the user/config setting name that toggles the legend, which is unchanged).
• The legend markup lives in includes/controller.php, which is already on the patch-coverage $unmeasured_allowlist; CSS files are not coverage-gated.

Types of changes

• New feature (non-breaking change which adds functionality)

Checklist:

• My code follows the code style of this project.

[Copilot]

Copilot review overview

🟡 Changes recommended

Both Up-chip colours have insufficient white-text contrast for WCAG AA compliance.

Review effort: Balanced
Findings: 2

Open (2)

• Darken Deepness emerald to meet Up label contrast requirements · New
• Increase Up status green contrast to meet WCAG AA · New

What changed in this PR

Redesigns the Monitor status legend as theme-aware, wrapping colour chips while preserving existing device-tile styling.

Changes:

• Replaces legacy legend markup and fixed positioning.
• Adds solid semantic colours with a Deepness-specific accent.
• Removes obsolete theme overrides and documents the change.

File	Description
includes/​controller.php	Emits the new legend chip markup.
css/​monitor.css	Defines shared chip layout and colours.
css/​deepness.css	Adds the Deepness Up-chip accent.
css/​classic.css	Removes the legacy legend override.
css/​dark.css	Removes the legacy legend override.
css/​midwinter.css	Enables the redesigned legend.
css/​modern.css	Removes the legacy legend override.
css/​paper-plane.css	Removes the legacy legend override.
css/​paw.css	Removes the legacy legend override.
css/​sunrise.css	Removes legacy positioning and colouring.
CHANGELOG.md	Records the legend redesign.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.