chore: PHPStan level 8 typing pass + bugfixes

[TheWitness]

Summary

PHPStan level 8 + PHPDoc/native typing pass for plugin_apcupsd, following the same process as the prior repos in this rollout. Native return types added where a function's own body guarantees a single type; PHPDoc-only types kept at Cacti hook-boundary functions (apcupsd_replicate_out, apcupsd_draw_navigation_text) whose arguments are supplied by an external dispatcher.

(a) Error count

PHPStan level 8: 38 -> 0 errors.

(b) Genuine bugs fixed

• poller_apcupsd.php: both calls to add_ups_device($ups, $host_template_id, ...) referenced $host_template_id, which is never defined anywhere in the script - every newly-discovered UPS device was created with a null/undefined host template id instead of the imported APC UPS Host Template. Fixed by resolving the real template id via the same host_template.hash = APCUPSD_HOST_TEMPLATE_HASH query already used (existence-only) by apcupsd_host_template_imported().
• setup.php: plugin_apcupsd_install() registered the replicate_out hook twice (an apparent copy/paste leftover, one labeled "hook for table replication"), which would run apcupsd_replicate_out() twice per replication event; removed the duplicate registration.
• setup.php: apcupsd_config_arrays() added the "UPSes" menu entry with the wrong text domain ('webseer' instead of 'apcupsd'), silently breaking translation for that one menu label. Fixed.
• upses.php: the Location filter dropdown's "selected" check compared against get_request_var('site_id') instead of get_request_var('location') - a copy/paste bug from the adjacent Site dropdown block - so the Location dropdown never correctly reflected the currently-selected location. Fixed.
• upses.php: form_actions()'s $save_html was only assigned inside the 3 known drp_action branches (1-3), and $ups_actions[get_nfilter_request_var('drp_action')] was indexed with the same unrestricted value, but drp_action is only regex-validated (any alphanumeric string is accepted) - matches the exact same bug shape Copilot flagged in the plugin_tags PR earlier in this rollout. Fixed proactively with the same "reject any value outside the known set up front" pattern.
• upses.php's edit form field array ($fields_ups_edit['host_id']) had a duplicate 'none_value' key (__('None') immediately overwritten by __('Autocreate on First Poll', 'apcupsd') two lines later) - removed the dead first occurrence.
• poller_apcupsd.php: collect_ups_data() appended to $sql_params[] without initializing it first - works via PHP's array auto-vivification but raises an "Undefined variable" warning on every apcaccess-based poll; added the missing $sql_params = array();.
• db_fetch_row_prepared()/db_fetch_row() results (which can be false) narrowed to arrays before offset access in form_save(), ups_edit(), and duplicate_ups().
• setup.php: parse_ini_file() result narrowed before array access (can return false).
• setup.php/upses.php: $config/superglobal narrowing at include boundaries and one always-true isset($_POST) simplification, matching the recurring pattern from every prior repo in this rollout.
• upses.php: html_start_box() $div/$cell_padding args fixed to native bool/int in 4 call sites.

(c) Stubs added/verified

Scratch PHPStan bootstrap stubs added for this repo's many Cacti core dependencies (api_device_save, automation_update_device, cacti_snmp_get, push_out_host, array_rekey, api_reapply_suggested_graph_title, update_graph_title_cache, api_reapply_suggested_data_source_data, update_data_source_title_cache, get_colored_device_status, form_text_box, api_plugin_is_enabled, api_plugin_enable_hooks, db_column_exists, replicate_out_table, auth_augment_roles, form_selectable_ecell, cacti_escapeshellcmd, cacti_escapeshellarg, plus the already-established reusable base set), all sourced from Cacti/cacti's develop branch. $fields_snmp_item (a real Cacti core global from include/global_form.php, loaded transitively via upses.php's own auth.php bootstrap at runtime) stubbed as an empty array for static-analysis purposes only.

(d) Test result

Full Pest suite: 68 passed (176 assertions), run against the real 1.2.x host via bind-mount, unchanged before and after this pass. php-cs-fixer (Cacti develop config, array() -> [] shorthand applied) and php -l both clean on all touched files.

(e) Unresolved / flagged for maintainer judgement

None.

Files changed

apcupsd_functions.php, database.php (cs-fixer style only), poller_apcupsd.php, setup.php, ui_helpers.php, upses.php, locales/po/cacti.pot (translation template refresh only; per-language .po/.mo files reverted to avoid Weblate churn).

[Copilot]

Copilot review overview

🟡 Changes recommended

The duplicate-hook migration and malformed configuration-section handling remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1 · 1

Open (3)

• Remove duplicate replicate_out hooks during upgrade · New
• Validate INFO section before accessing it · New
• Use cacti_sizeof() for compatibility · New

What changed in this PR

Adds PHPStan level 8 typing and fixes polling, setup, filtering, validation, and translation issues in the APCUPSD plugin.

Changes:

• Adds native typing and modernizes array syntax.
• Fixes host-template resolution, duplicate hooks, filters, and bulk-action validation.
• Refreshes translation references and poller initialization.

File	Summary
upses.php	Form handling, filtering, validation, and UI fixes
ui_helpers.php	Layout helper typing
setup.php	Lifecycle, hook, menu, and configuration updates
poller_apcupsd.php	Poller typing and host-template resolution
locales/​po/​cacti.pot	Translation template refresh
database.php	Array syntax modernization
apcupsd_functions.php	Helper return typing

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.