Conversation
Changed a tags to button tags as dropdown titles no longer navigate to pages, got rid of additional item for mobile dropdowns for same reason openning a new dropdown closes others on mobile
Dropdown buttons identify the menu they control, Added aria JavaScript updates aria-expanded whenever a mobile dropdown changes
Fixed hamburger menu from filling the whole navbar Mobile menu closes if viewport crosses above 1050px (when desktop)
Made JS prettier
github-actions
Bot
added
the
sync
|
This pull request has been marked to automatically sync to its base branch. You can disable this behavior by removing the label. |
cssbhamdev
enabled auto-merge (squash)
September 4, 2026 11:37
gellowg
marked this pull request as draft
September 4, 2026 11:39
auto-merge was automatically disabled
September 4, 2026 11:39
Pull request was converted to draft
Update navigation to use nav landmarks and list-based markup for desktop and mobile layouts. Represent dropdown contents as nested lists so for accessibility reasons (makes the relationship between categories and their links clear)
Remove the rule that stops outlines from mobile navigation links so keyboard users can identify the currently focused item. Specified the outline style for high contrast with the current dark background. Satisfies WCAG 2.4.7 Focus Visible
Keep pointer hover as an optional way to reveal dropdown links. Toggle each dropdown through its native button so click, touch, Enter, and Space work without hover. Close open dropdowns with Escape or an outside pointer action, return focus to the dismissed trigger, and keep the visual state synchronized with aria-expanded.
Wait 300 milliseconds before closing a hover-opened submenu after the pointer leaves. Cancel the pending timer when the pointer returns, the dropdown closes another way, or keyboard focus remains inside.
Change ball card css to accommodate extra line on wider screens
Remove Calendar from events dropdown as it is on events page
…eperator lines, added hover state with animation, reduce freshers graphic size
… allow menu to scroll when content too tall, add new menu open/close animation, keep logo and close button above sliding panel, make menu pass below the top bar (had to add header bg layer), match nav colour to bg colour when menu open
…ob.github.io into reorganise-main-menu
…l, add morph effect for hamburger icon
…rrowhead icon and rotate on hover, redesign dropdown, add keyboard focus styling for accessibility, left align mobile menu items, fix join css CTA, rename community links to links
…ob.github.io into reorganise-main-menu
…iables for Ball pages
gellowg
marked this pull request as ready for review
September 12, 2026 19:53
cssbhamdev
enabled auto-merge (squash)
September 12, 2026 19:54
This reverts commit 5441b63.
Page defaults to assuming JS is not available. When navigation JS loads it adds a JS class to <html>. Without that class, desktop dropdown is opened on hover or keyboard focus.
gellowg
force-pushed
the
reorganise-main-menu
branch
from
September 13, 2026 00:36
394fd49 to
8e1d4b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR reorganises and redesigns the main navigation to make important pages easier to find while keeping the menu compact. It also improves keyboard, screen-reader and mobile behaviour, and ensures the shared navigation works with the standard, Freshers and Ball visual themes.
Changes
Navigation structure
Desktop navigation
Mobile navigation
Feedback