Skip to content

Implement automatic AssignedCommitteeAction reminders - #496

Draft
MattyTheHacker wants to merge 260 commits into
mainfrom
453-action-reminders
Draft

MattyTheHacker wants to merge 260 commits into
mainfrom
453-action-reminders

Conversation

@MattyTheHacker

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements automatic reminders for assigned committee actions by introducing new configuration options and a background task.

  • Adds environment settings for enabling reminders and configuring their interval.
  • Introduces get_user_actions helper to centralize action-fetching logic and refactors existing list commands to use it.
  • Defines a new CommitteeActionsTrackingRemindersTaskCog to run a periodic Discord reminder task.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
config.py Added _setup_committee_actions_reminders and _setup_committee_actions_reminders_interval to parse new env vars.
cogs/committee_actions_tracking.py Added get_user_actions overloads, refactored list commands, and created the reminders task cog.
cogs/init.py Registered CommitteeActionsTrackingRemindersTaskCog.
Comments suppressed due to low confidence (1)

cogs/committee_actions_tracking.py:205

  • [nitpick] There are no tests covering the background reminders task. Adding unit tests for the enabled/disabled path and interval parsing would ensure this feature works reliably.
@tasks.loop(**settings["COMMITTEE_ACTIONS_REMINDERS_INTERVAL"])

Comment thread cogs/committee_actions_tracking.py Outdated
Comment thread config.py Outdated
Comment thread config.py Outdated
Comment thread cogs/committee_actions_tracking.py Outdated
@MattyTheHacker
MattyTheHacker marked this pull request as ready for review May 22, 2025 16:36
@MattyTheHacker
MattyTheHacker enabled auto-merge (squash) May 22, 2025 16:36
@MattyTheHacker
MattyTheHacker requested a review from Copilot May 22, 2025 16:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements automatic reminders for AssignedCommitteeAction by adding new configuration settings and a background task that periodically notifies committee members about their pending actions.

  • Adds configuration methods in config.py to validate and store committee reminders settings and intervals.
  • Implements a new reminders task cog in cogs/committee_actions_tracking.py that schedules reminder messages.
  • Registers the new reminders cog in cogs/init.py.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
config.py Introduces methods to configure committee action reminders and validates environment variables.
cogs/committee_actions_tracking.py Adds the reminders task cog, overloads for get_user_actions, and updates list commands to use the new reminder mechanism.
cogs/init.py Registers the new CommitteeActionsTrackingRemindersTaskCog.
Comments suppressed due to low confidence (1)

config.py:757

  • [nitpick] The variable name 'raw_timedelta_committee_actions_reminders_interval' is quite verbose; consider renaming it to a shorter, more descriptive name like 'reminder_interval_dict' for improved clarity.
raw_timedelta_committee_actions_reminders_interval: Mapping[str, float] = {

Comment thread cogs/committee_actions_tracking.py
@MattyTheHacker MattyTheHacker linked an issue May 23, 2025 that may be closed by this pull request
@automatic-pr-updater

Copy link
Copy Markdown
Contributor

This pull request has a merge conflict with the base branch! Please resolve the conflict manually, remove the conflict label and re-add the filter label (if applicable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict A bot has identified that this PR has a conflict, preventing automatic syncing to the base branch enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement persistent actions tracker Implement reminders for actions

5 participants