Implement automatic AssignedCommitteeAction reminders - #496
MattyTheHacker wants to merge 260 commits into
Conversation
20e6524 to
546327d
Compare
There was a problem hiding this comment.
Pull Request Overview
Implements automatic reminders for assigned committee actions by introducing new configuration options and a background task.
- Adds environment settings for enabling reminders and configuring their interval.
- Introduces
get_user_actionshelper to centralize action-fetching logic and refactors existing list commands to use it. - Defines a new
CommitteeActionsTrackingRemindersTaskCogto run a periodic Discord reminder task.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| config.py | Added _setup_committee_actions_reminders and _setup_committee_actions_reminders_interval to parse new env vars. |
| cogs/committee_actions_tracking.py | Added get_user_actions overloads, refactored list commands, and created the reminders task cog. |
| cogs/init.py | Registered CommitteeActionsTrackingRemindersTaskCog. |
Comments suppressed due to low confidence (1)
cogs/committee_actions_tracking.py:205
- [nitpick] There are no tests covering the background reminders task. Adding unit tests for the enabled/disabled path and interval parsing would ensure this feature works reliably.
@tasks.loop(**settings["COMMITTEE_ACTIONS_REMINDERS_INTERVAL"])
There was a problem hiding this comment.
Pull Request Overview
This PR implements automatic reminders for AssignedCommitteeAction by adding new configuration settings and a background task that periodically notifies committee members about their pending actions.
- Adds configuration methods in config.py to validate and store committee reminders settings and intervals.
- Implements a new reminders task cog in cogs/committee_actions_tracking.py that schedules reminder messages.
- Registers the new reminders cog in cogs/init.py.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| config.py | Introduces methods to configure committee action reminders and validates environment variables. |
| cogs/committee_actions_tracking.py | Adds the reminders task cog, overloads for get_user_actions, and updates list commands to use the new reminder mechanism. |
| cogs/init.py | Registers the new CommitteeActionsTrackingRemindersTaskCog. |
Comments suppressed due to low confidence (1)
config.py:757
- [nitpick] The variable name 'raw_timedelta_committee_actions_reminders_interval' is quite verbose; consider renaming it to a shorter, more descriptive name like 'reminder_interval_dict' for improved clarity.
raw_timedelta_committee_actions_reminders_interval: Mapping[str, float] = {
|
This pull request has a merge conflict with the base branch! Please resolve the conflict manually, remove the conflict label and re-add the filter label (if applicable). |
No description provided.