Development - #258
Merged
Merged
Conversation
c-popover, c-menu and c-tooltip accept a trigger prop (a document ID or an element reference) designating an element elsewhere in the document as the trigger: the component wires its usual opening interaction, ARIA mirroring and focus return onto it and anchors the panel to it via a measured proxy anchor (anchor names are tree-scoped, so the shadow panel cannot reference an outer-tree element). The prop wins over a simultaneously slotted trigger. Nested c-popovers are coordinated by a shared popover chain controller: Escape peels the innermost popover one press at a time, light dismiss closes exactly the popovers that do not logically contain the pointer event, and closing a popover closes its descendants. Containment follows the trigger relationship, not DOM ancestry. Records ADR-0038 and the CONTEXT.md Trigger/Popover chain vocabulary. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tor colour (ADR-0039)
The keyboard focus ring of c-checkbox and c-radio moves from the part-less
ripple surface onto the `indicator` part as a `::before` halo drawn with
currentColor, and the checkbox indicator now draws its border and checked
fill from the same colour channel. One `::part(indicator) { color }` rule
recolours box, dot and focus ring together; hover tint and ripple stay
internal. Ring geometry is unchanged (ripples move into a dedicated clipped
layer so the halo is not clipped). c-switch is deliberately unchanged.
Also: ADR-0039 (rejected alternatives recorded), amendment note in ADR-0035,
glossary entry for the focus ring plus flagged "ring"/"themeable"
ambiguities, updated usage docs, changeset, and the plan of record.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…us ring The native `` element previously displayed a browser focus ring around the entire modal, as it received focus as a fallback. This is suppressed as it acts as a focus start point, not an interactive control. Initial focus is now reliably set to the first focusable element (or `[autofocus]`) even when the modal opens at mount. Previously, the focus search ran before slotted custom elements had upgraded, causing focus to improperly fall back to the dialog itself.
✅ Deploy Preview for csc-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
razorfever
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.