Repository navigation
fix(www): tidy layout, dark-mode selection and landing copy - #421
Open
simonvanlierde wants to merge 6 commits into
Open
simonvanlierde wants to merge 6 commits into
simonvanlierde wants to merge 6 commits into
Conversation
- Keep the 1rem side gutter below 760px, so body text starts where the header and footer do - Drop the inline padding on read-page intros, which set the title 6px right of the body - Give the first read-page heading the same space above it as the rest - Narrow the read-page column from 44rem to 40rem, about 80 characters a line
The selection colour mixed the primary into white, so dark mode put near-white text on a near-white highlight. Mix it into the page ground instead.
… whole - The three motivation headings are phrases, so they take the subhead role instead of mono, which is kept for measurements - The hero title no longer breaks "circular-economy" at its hyphen on phones
… exists - count components, not parts, in the hero figure, stats panel and teardown caption, and date the hero figure since it is fixed at build time - the method lede says a finished record becomes browsable, not published - the method paragraph keeps to what a record is for; the motivation section owns the as-designed versus as-found argument - the third motivation beat names what contributors get back and says it comes in a later release - the looping method phase is marked "repeats", since its name already says per component
…inly - describe the current behaviour instead of what an earlier value did - say why the first read-page heading keeps its top margin - make the 404 explanation read as two parallel possibilities
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const html = await render(); | ||
| expect(html).toContain('Open product data for circular-economy research'); | ||
| const title = html.match(/<h1[^>]*>([\s\S]*?)<\/h1>/)?.[1] ?? ''; | ||
| expect(title.replace(/<[^>]+>/g, '').trim()).toBe( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page text now lines up with the header and footer, and the landing copy says only what the platform does today.