Repository navigation
test(backend): pin oauth and mfa error details that mutants survived - #418
Merged
Merged
Conversation
- OAuth login callback: pin the provider arguments, the error and success redirects, and the MFA transport chosen from the backend - OAuth associate callback: pin the existing-link lookup, the provider arguments, the updated user in the response and the link notification - MFA challenge: pin failure reasons, the bad-credentials detail, the success audit event, the guess budget key and the session transport path - Account update step-up: pin the refusal details, the missing-request error and the recovery code burn; add its mutation baseline line Closes #409
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Survivor counts from a mutation run of the auth-flows shard on this branch. Most of the 18 left in handle_oauth_associate_callback are cast() type strings, which do nothing at runtime.
…ertions * origin/main: feat!: move to r9lab.io and rename the product to R9lab (#417) # Conflicts: # backend/tests/integration/api/auth/test_oauth_callbacks.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the assertions that mutation testing showed were missing for the auth flows (group 1 of #409): OAuth login and associate callbacks,
complete_mfa_challenge,audit_mfa_failureandrequire_account_update_step_up. Closes #409.complete_mfa_challengefrom 41 to 0. Most of the 18 left in the associate callback arecast()type strings.