Repository navigation
Run the StyleEditor tests in the browser project; un-skip the two that need it (BL-16925) - #8411
Conversation
…that need it (BL-16925) Two StyleEditor tests had been skipped since the move to Vitest because they read computed styles, which jsdom doesn't support. The file is now StyleEditor.browser.spec.ts, so all 23 of its tests run in headless Edge, and those two run again. That leaves no skipped tests in the Vitest suite. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
[Claude Opus 5.5] Consulted Devin on 2026-09-25 up to commit 62a8ad0. Clean: no bugs and no flags. |
|
[Low risk] Moves style editor tests to browser test runner. The PR appears safe to merge, though the browser test should avoid its known failed API requests. SummaryThe PR moves the StyleEditor spec from jsdom to headless Edge and enables two tests that require computed styles.
Reviews (1) · Last reviewed commit: "Run the StyleEditor tests in the browser..." |
|
[Claude Opus 5.5] Re Greptile's note about avoidable failed API requests: two tests reach |
Problem. After #8408, the nightly still skipped 2 Vitest tests, both in the StyleEditor spec: "…MakeBigger replaces the existing rule" and "…ChangeSizeAbsolute replaces the existing rule". They were skipped in the Vitest move because they read computed styles (
getComputedStyle), which jsdom doesn't really support. The same reason had kept the overflow tests off.Fix. Rename
StyleEditorSpec.tstoStyleEditor.browser.spec.ts, so the whole file runs in thebrowserVitest project (headless Edge) added in #8408, and un-skip the two tests. All 23 pass there. The two now-obsolete "skipped because jsdom" comments are gone, and one line at the top says why the file runs in the browser.Result:
pnpm testruns 969 tests with none skipped (the last nightly had 967 passed, 2 skipped).While these tests run, StyleEditor asks Bloom for
fonts/metadata. With no Bloom to answer, the request fails and a "*****Got error trying report preliminaryError" line is logged. It's harmless: under jsdom the same failure is filtered out byvitest.setup.ts.Ref: https://issues.bloomlibrary.org/youtrack/issue/BL-16925
🤖 Generated with Claude Code
Devin review
This change is