Housekeeping#26
Merged
Merged
Conversation
ruby - 3.2.2 -> 3.4.9 gems: - rubyzip v3+ is out of alpha and can be upgraded at least to ~3.0 docker-compose: - I got some warnings about running geoserver container without a platform specification, so I added a linux/amd64 to both. - rspec tests were giving errors because the geoserver containers weren't fully up when running the test, so I added healthchecks - since I added healthchecks for geoserver services, I added one to solr, and a server_started to the spatial service test change: - from what I can tell there was just a typo in one test which I fixed. (I think it may have been missed before because the app wasn't waiting for the geoserver services to be up?)
danschmidt5189
approved these changes
Jun 16, 2026
danschmidt5189
left a comment
danschmidt5189
left a comment
Member
There was a problem hiding this comment.
Looks great, and I'm +1 on combining all these changes into one housekeeping PR. Not too bad to review (given the tests are passing).
yzhoubk
approved these changes
Jun 16, 2026
| ruby 3.4.9p82 | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.10 |
Contributor
There was a problem hiding this comment.
Should we also upgrade the bundle version?
jason-raitz
commented
Jun 16, 2026
Comment on lines
237
to
+241
| RUBY VERSION | ||
| ruby 3.2.2p53 | ||
| ruby 3.4.9p82 | ||
|
|
||
| BUNDLED WITH | ||
| 2.4.10 | ||
| 4.0.14 |
Contributor
Author
There was a problem hiding this comment.
I think this is as high as it can go @yzhoubk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version Bumps
Tooling updates
(geoserver was previously taking longer to start and tests would fail)
Typo in Test
Ticket references