Candidate/martonaczel - #144
Open
amarton5 wants to merge 4 commits into
Open
Conversation
Moved the exception handling in db query code for dashboard data up to the endpoint level. Made sure endpoint response HTTP 503 so frontend can show a targeted error instead of the mock data.
Add tenant_id for better isolation. Also use a global redis cache isntance that the `redis_client.py` implements only.
There is no backend route to get the properties list. This is a bugfixing activity so I implemented a filter for the hardcoded list. Proper way would be to implement and endpoint (feature building)
dashboard metric Frontend and backend both used arithmetics on the data. Moved this responsibility to the backend. No implemented monthly view, renamed for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finished the assignment and along with the video I made this PR to be prudent.
Cannot reproduce client a's issue:
Client b: