[connectedvmware] Fix cross-subscription VM onboarding - #10373
aaronngo-microsoft wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi aaronngo-microsoft, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Thank you for your contribution aaronngo-microsoft! We will review the pull request and get back to you soon. |
|
connectedvmware |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changes are focused, correctly scoped, and covered by unit and live-test paths.
Review effort: Lite
Findings: None
What changed in this PR
Fixes create-from-machines for machines and vCenters in different subscriptions.
Changes:
- Scopes Resource Graph queries to both subscriptions while filtering machines to the active subscription.
- Adds unit and live cross-subscription coverage.
- Updates help examples, changelog, and extension version.
| File | Description |
|---|---|
src/connectedvmware/setup.py |
Bumps version to 1.2.2 |
src/connectedvmware/HISTORY.rst |
Documents the fix |
src/connectedvmware/azext_connectedvmware/custom.py |
Implements cross-subscription query handling |
src/connectedvmware/azext_connectedvmware/_help.py |
Adds subscription examples |
src/connectedvmware/azext_connectedvmware/tests/latest/test_custom.py |
Adds deterministic unit coverage |
src/connectedvmware/azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py |
Adds live scenario coverage |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedvmware vm create-from-machinesSummary
Fix
create-from-machineswhen the Hybrid Compute machine and vCenter inventory are in different subscriptions.--subscriptioncontext as the machine subscription.connectedvmwareto version1.2.2and updateHISTORY.rst.Testing
python -m unittest azext_connectedvmware.tests.latest.test_custom azext_connectedvmware.vmware_utils_test— 14 tests passed.AZURE_CONNECTEDVMWARE_TEST_*environment variables.General Guidelines
azdev style connectedvmwarelocally? (azdevis not configured in this environment; targeted Flake8 checks passed.)python scripts/ci/test_index.py -qlocally? (src/index.jsonis unchanged.)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once this pull request is merged into main, a new pull request will update
src/index.jsonautomatically.This pull request updates
setup.pyandHISTORY.rstand does not modifysrc/index.json.