[Application Insights] Pre-announce query offset default change - #10372
Igor Babichev (netgh0st) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb41df1a-e62f-43af-938a-67db646f2353
|
Hi Igor Babichev (@netgh0st), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The notification-only changes are documented and do not alter current command behavior.
Review effort: Lite
Findings: None
What changed in this PR
This PR pre-announces the planned --offset default change for az monitor app-insights query without changing current behavior.
Changes:
- Bumps the extension version to
2.0.0b2. - Documents the upcoming breaking change.
- Registers and loads the notification targeting
3.0.0b1.
| File | Description |
|---|---|
src/application-insights/setup.py |
Updates the extension version. |
src/application-insights/HISTORY.rst |
Documents the upcoming breaking change. |
src/application-insights/azext_applicationinsights/_breaking_change.py |
Registers the default-value notification and issue link. |
src/application-insights/azext_applicationinsights/__init__.py |
Loads the breaking-change registration module. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
The release metadata guidance is addressed: |
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
|
monitor |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb41df1a-e62f-43af-938a-67db646f2353
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
🤖 PR Validation — ️✔️ All clear
Related command
az monitor app-insights querySummary
Pre-announce the breaking default-value change planned for
application-insightsextension version3.0.0b1.Today,
--offsetdefaults to1h. The follow-up implementation will remove that implicit default so that, when no CLI time arguments are supplied, the KQL query controls the time range. Customers who require the current behavior can continue to specify--offset 1hexplicitly.This notification-only PR:
--offsetdefault change from1hto not set, targeting3.0.0b1;2.0.0b2; andFollow-up implementation: #10364. It should merge and release only after this notification has been released for at least 30 days.
Validation
application_insights-2.0.0b2wheel and verified its package metadata.--offsetwill change from1hto not set in3.0.0b1and links to [Application Insights] Remove implicit one-hour offset from app-insights query #10363.azdev generate-breaking-change-report application-insights --target-version None --source pre_announce; the report collected the expected warning undermonitor app-insights query.azdev style application-insightspasses.python scripts/ci/test_index.py -qpasses.git diff --checkand Python compilation pass.General Guidelines
azdev style application-insightslocally?python scripts/ci/test_index.py -qlocally?About Extension Publish
This PR updates
setup.pyandHISTORY.rstand does not modifysrc/index.json. The normal post-merge publishing automation should create the index update.