Rename aks-custom-headers to custom-headers for aimanager - #10367
Jessie (techworldhello) wants to merge 3 commits into
Conversation
|
Hi Jessie (@techworldhello), |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Correct the HISTORY.rst heading underlines and continuation indentation in _params.py.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Renames AI Manager’s AKS-specific custom-header option and related helpers to generic custom-headers, with updated tests, metadata, and release history.
Changes:
- Replaces
--aks-custom-headerswith--custom-headers. - Renames related helper and parameter references.
- Updates tests, versions, and changelog entries.
| File | Summary |
|---|---|
src/aimanager/setup.py |
Version bump. |
src/aimanager/HISTORY.rst |
Release history updates. |
src/aimanager/azext_aimanager/tests/latest/test_namespace_accesskeys.py |
Updated unit test references. |
src/aimanager/azext_aimanager/tests/latest/test_namespace_accesskeys_scenario.py |
Updated scenario test references. |
src/aimanager/azext_aimanager/tests/latest/test_aimanager_helpers.py |
Updated helper tests. |
src/aimanager/azext_aimanager/custom.py |
Updated request-header handling. |
src/aimanager/azext_aimanager/azext_metadata.json |
Updated extension metadata. |
src/aimanager/azext_aimanager/_params.py |
Registers the renamed CLI option. |
src/aimanager/azext_aimanager/_helpers.py |
Renamed header parser references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
aimanager |
| help='Delete options of the AI Manager. Defaults to Delete.') | ||
| c.argument('aks_custom_headers', options_list=['--aks-custom-headers'], | ||
| help='Comma-separated key=value pairs to specify custom headers.') | ||
| c.extra('custom_headers', options_list=['--custom-headers'], |
There was a problem hiding this comment.
c.argument updated to c.extra because Azure CLI excludes 'custom_headers' name from automatic discovery https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/__init__.py#L27
It fails with error unrecognized arguments: --custom-headers a=1,b=2 if we keep it as .argument('custom_headers',...
3660429 to
a5b4252
Compare
a5b4252 to
301a680
Compare
|
|
||
| def extra(self, name, *args, **kwargs): | ||
| self.argument(name, *args, **kwargs) | ||
|
|
There was a problem hiding this comment.

🤖 PR Validation — ❌ Action needed
❌Azure CLI Extensions Breaking Change Test
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Rename aks-custom-headers to custom-headers for aimanager
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.