Skip to content

Rename aks-custom-headers to custom-headers for aimanager - #10367

Open
Jessie (techworldhello) wants to merge 3 commits into
Azure:mainfrom
techworldhello:wangjessi/update-custom-header-flag
Open

Jessie (techworldhello) wants to merge 3 commits into
Azure:mainfrom
techworldhello:wangjessi/update-custom-header-flag

Conversation

@techworldhello

@techworldhello Jessie (techworldhello) commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

🤖 PR Validation — ❌ Action needed

Breaking Changes
❌ 1
❌Azure CLI Extensions Breaking Change Test
❌aimanager
rule cmd_name rule_message suggest_message
1007 - ParaRemove aimanager create cmd aimanager create removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager create
1007 - ParaRemove aimanager get-credentials cmd aimanager get-credentials removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager get-credentials
1007 - ParaRemove aimanager modelsource add cmd aimanager modelsource add removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager modelsource add
1007 - ParaRemove aimanager modelsource update cmd aimanager modelsource update removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager modelsource update
1007 - ParaRemove aimanager namespace add cmd aimanager namespace add removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace add
1007 - ParaRemove aimanager namespace get-credentials cmd aimanager namespace get-credentials removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace get-credentials
1007 - ParaRemove aimanager namespace list-accesskeys cmd aimanager namespace list-accesskeys removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace list-accesskeys
1007 - ParaRemove aimanager namespace modeldeployment add cmd aimanager namespace modeldeployment add removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace modeldeployment add
1007 - ParaRemove aimanager namespace modeldeployment update cmd aimanager namespace modeldeployment update removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace modeldeployment update
1007 - ParaRemove aimanager namespace rotate-accesskeys cmd aimanager namespace rotate-accesskeys removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace rotate-accesskeys
1007 - ParaRemove aimanager namespace update cmd aimanager namespace update removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager namespace update
1007 - ParaRemove aimanager update cmd aimanager update removed parameter aks_custom_headers please add back parameter aks_custom_headers for cmd aimanager update
⚠️ 1006 - ParaAdd aimanager create cmd aimanager create added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager get-credentials cmd aimanager get-credentials added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager modelsource add cmd aimanager modelsource add added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager modelsource update cmd aimanager modelsource update added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace add cmd aimanager namespace add added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace get-credentials cmd aimanager namespace get-credentials added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace list-accesskeys cmd aimanager namespace list-accesskeys added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace modeldeployment add cmd aimanager namespace modeldeployment add added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace modeldeployment update cmd aimanager namespace modeldeployment update added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace rotate-accesskeys cmd aimanager namespace rotate-accesskeys added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager namespace update cmd aimanager namespace update added parameter custom_headers
⚠️ 1006 - ParaAdd aimanager update cmd aimanager update added parameter custom_headers

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Rename aks-custom-headers to custom-headers for aimanager

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install azdev required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI lite review requested due to automatic review settings September 21, 2026 00:22
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi Jessie (@techworldhello),
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Correct the HISTORY.rst heading underlines and continuation indentation in _params.py.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Renames AI Manager’s AKS-specific custom-header option and related helpers to generic custom-headers, with updated tests, metadata, and release history.

Changes:

  • Replaces --aks-custom-headers with --custom-headers.
  • Renames related helper and parameter references.
  • Updates tests, versions, and changelog entries.
File Summary
src/​aimanager/​setup.py Version bump.
src/​aimanager/​HISTORY.rst Release history updates.
src/​aimanager/​azext_aimanager/​tests/​latest/​test_namespace_accesskeys.py Updated unit test references.
src/​aimanager/​azext_aimanager/​tests/​latest/​test_namespace_accesskeys_scenario.py Updated scenario test references.
src/​aimanager/​azext_aimanager/​tests/​latest/​test_aimanager_helpers.py Updated helper tests.
src/​aimanager/​azext_aimanager/​custom.py Updated request-header handling.
src/​aimanager/​azext_aimanager/​azext_metadata.json Updated extension metadata.
src/​aimanager/​azext_aimanager/​_params.py Registers the renamed CLI option.
src/​aimanager/​azext_aimanager/​_helpers.py Renamed header parser references.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/aimanager/azext_aimanager/_params.py Outdated
@yonzhan

Copy link
Copy Markdown
Collaborator

aimanager

Comment thread src/aimanager/HISTORY.rst Outdated
Comment thread src/aimanager/azext_aimanager/_params.py Outdated
Comment thread src/aimanager/azext_aimanager/_params.py Outdated
Comment thread src/aimanager/azext_aimanager/custom.py Outdated
Comment thread src/aimanager/azext_aimanager/_params.py Outdated
help='Delete options of the AI Manager. Defaults to Delete.')
c.argument('aks_custom_headers', options_list=['--aks-custom-headers'],
help='Comma-separated key=value pairs to specify custom headers.')
c.extra('custom_headers', options_list=['--custom-headers'],

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c.argument updated to c.extra because Azure CLI excludes 'custom_headers' name from automatic discovery https://github.com/Azure/azure-cli/blob/dev/src/azure-cli-core/azure/cli/core/__init__.py#L27

It fails with error unrecognized arguments: --custom-headers a=1,b=2 if we keep it as .argument('custom_headers',...

@techworldhello
Jessie (techworldhello) force-pushed the wangjessi/update-custom-header-flag branch from 3660429 to a5b4252 Compare September 21, 2026 07:18
@techworldhello
Jessie (techworldhello) force-pushed the wangjessi/update-custom-header-flag branch from a5b4252 to 301a680 Compare September 21, 2026 07:34

def extra(self, name, *args, **kwargs):
self.argument(name, *args, **kwargs)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants