fix: default to scriptless phase 2, since its default in prod now

[awesomenix]

scriptless phase 2 is default, dont run other tests

[Copilot]

Pull request overview

This PR updates the E2E harness to make the “scriptless phase 2” (scriptless_nbc) path the default subtest, removing the old per-scenario opt-out (SkipScriptlessNBC) and updating scenarios that previously forced the legacy/default path.

Changes:

• Removed Config.SkipScriptlessNBC and corresponding uses across multiple E2E scenarios.
• Updated RunScenario to run only scriptless_nbc by default (falling back to default only when scriptless is unsupported).
• Cleaned up scenario configs in GPU, daemonset, and CSE performance tests to no longer set SkipScriptlessNBC.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
e2e/types.go	Removes SkipScriptlessNBC from the E2E scenario config.
e2e/test_helpers.go	Changes scenario execution to prefer scriptless_nbc and introduces scriptlessUnsupported gating.
e2e/scenario_test.go	Removes SkipScriptlessNBC from multiple scenarios (but one usage remains).
e2e/scenario_gpu_managed_experience_test.go	Removes SkipScriptlessNBC from GPU managed experience scenarios.
e2e/scenario_gpu_daemonset_test.go	Removes SkipScriptlessNBC from GPU daemonset scenario.
e2e/scenario_cse_perf_test.go	Removes SkipScriptlessNBC from CSE performance scenarios.

Comments suppressed due to low confidence (1)

e2e/types.go:242

• SkipScriptlessNBC was removed from Config, but there is still at least one remaining usage (e2e/scenario_test.go still sets SkipScriptlessNBC: true, e.g. in Test_AzureLinuxV2). This will not compile until that last reference is removed or replaced with a new opt-out mechanism.

	// The assertion is performed inside the scenario's subtest.
	ExpectedError string

	// UseNVMe indicates whether to use NVMe-based disk placement/controller. This is required for certain VM sizes (e.g., v6 and v7 series) which only support NVMe disk controllers.
	UseNVMe bool

	// EagerCSETimingExtraction when true causes CSE timing events to be extracted
	// immediately after SSH is established, before other validators run.
	// This prevents the Guest Agent from sweeping events before they can be read.
	// Only set this on CSE performance test scenarios.
	EagerCSETimingExtraction bool

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

e2e/cluster.go:188

• The error from EnsureDebugDaemonsets is now ignored. If daemonset creation or proxy ConfigMap setup fails, the cluster will still be considered ready and later failures will be harder to diagnose (and GetProxyURL may not work as expected). Handle and propagate the error here, like before.

		k.EnsureDebugDaemonsets(ctx, isNetworkIsolated, config.GetPrivateACRName(true, *cluster.Location))
		if isNetworkIsolated {
			return "", nil
		}
		return k.GetProxyURL(ctx)

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

e2e/cluster.go:189

• The error returned by EnsureDebugDaemonsets is currently ignored. If daemonset creation or proxy config setup fails, prepareCluster will still proceed and may later fail in less obvious ways (or return a Cluster missing debug/proxy functionality). Propagate the error so the DAG fails fast with the real root cause.

	proxyURL := dag.Go1(g, kubeForDebug, func(ctx context.Context, k *Kubeclient) (string, error) {
		k.EnsureDebugDaemonsets(ctx, isNetworkIsolated, config.GetPrivateACRName(true, *cluster.Location))
		if isNetworkIsolated {
			return "", nil
		}
		return k.GetProxyURL(ctx)
	}, debugDeps...)