Unify Settings cards - #4543
Draft
shaunandrews wants to merge 2 commits into
Draft
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Codex separated the shared card language from the broader settings redesign, introduced a reusable card primitive, migrated the Keyboard, Skills, and MCP surfaces, and verified the layouts at desktop and narrow widths in both color schemes. The final diff and rendered UI were reviewed interactively.
Proposed Changes
This PR intentionally preserves all six Settings tabs and does not relocate any controls. It improves the current interface on its own while preparing the next layers of the stack.
Screenshots
Testing Instructions
npm run cli:build:ui && node apps/cli/dist/cli/main.mjs ui --no-open.Verified on this branch:
npx eslint --fixon all modified TypeScript filesnpm run typechecknpm test -- apps/ui/src/components/settings-view/skills-panel.test.tsx apps/ui/src/components/settings-view/mcp-panel.test.tsx apps/ui/src/components/settings-view/index.test.tsx(25 tests)npm run cli:build:uiPre-merge Checklist