Skip to content

Regenerate bundle-strings.pot after #4536 resync of release/1.18.0 from trunk - #4541

Merged
AliSoftware merged 2 commits into
release/1.18.0from
release-1.18.0-regenerate-pot
Aug 13, 2026
Merged

Regenerate bundle-strings.pot after #4536 resync of release/1.18.0 from trunk#4541
AliSoftware merged 2 commits into
release/1.18.0from
release-1.18.0-regenerate-pot

Conversation

@AliSoftware

@AliSoftware AliSoftware commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Related issues

N/A

How AI was used in this PR

No AI was harmed used in the making of this PR

Proposed Changes

Resynchronizing bundle-strings.pot after #4536

Why? / Context

The team recently decided to delay the Studio release 1.18.0 to Friday, Aug 14, and as a result merged all the recent commits from trunk into release/1.18.0 (via #4536) to incoroprate all the latest features/fixes from trunk in that 1.18.0 release.

As discussed in #4536 (comment), because this was done by merging trunk into the existing release/1.18.0 (that had been cut during the code-freeze one week ago on Aug 6)—as opposed to the release/1.18.0 branch being deleted and the code-freeze being re-done from scratch—this means that the generate_pot_file action that is usually called during code_freeze, to generate the bundle-strings.pot file with strings to be sent for translation, was not called again, and that bundle-strings.pot file was thus not updated with any new string that might have been added in trunk since Aug 6.

How? / The fix

To fix that, I've run npm install && bundle exec fastlane generate_pot_file from the release/1.18.0 manually (after #4536 got merged) to update the bundle-strings.pot, resulting the diff in this PR.

Note that I've encountered the The await using declaration should be first transformed by `@babel/plugin-transform-explicit-resource-management` errors in the logs when running this lane on my machine, but this is an unrelated known issue, for which there's already a Draft PR #4467

Testing Instructions

N/A Just check the diff makes sense

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@AliSoftware
AliSoftware requested a review from a team as a code owner August 13, 2026 20:18
@AliSoftware
AliSoftware changed the base branch from trunk to release/1.18.0 August 13, 2026 20:18
Re-running `bundle exec fastlane generate_pot_file` after #4536 merged `trunk` into the `release/1.18.0` branch, in order to make sure the `.pot` file that will be sent to translation picks up any latest strings that might have been added to `trunk` since the original code freeze that did it in 0d4d002
@AliSoftware
AliSoftware force-pushed the release-1.18.0-regenerate-pot branch from a47e09f to 15b0327 Compare August 13, 2026 20:29
@AliSoftware
AliSoftware requested a review from bcotrim August 13, 2026 20:29
@wpmobilebot

wpmobilebot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 7aa5d3c vs trunk

app-size

Metric trunk 7aa5d3c Diff Change
App Size (Mac) 1406.83 MB 1410.49 MB +3.66 MB 🔴 0.3%

site-editor

Metric trunk 7aa5d3c Diff Change
load 1049 ms 1060 ms +11 ms ⚪ 0.0%

site-startup

Metric trunk 7aa5d3c Diff Change
siteCreation 7514 ms 7528 ms +14 ms ⚪ 0.0%
siteStartup 2875 ms 3392 ms +517 ms 🔴 18.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks 👍

@AliSoftware
AliSoftware enabled auto-merge (squash) August 13, 2026 20:44
@AliSoftware

AliSoftware commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Important

The new strings added in this updated .pot won't be sent to GlotPress until you backmerge them all the way into trunk (i.e. that you create a backmerge PR from release/1.18.0 -> trunk once this PR has landed in release/1.18.0) and that the WPCOM scheduled job picks up that file from Automattic/studio/blob/trunk/i18n/bundle-strings.pot to send it to GlotPress

Given this, I doubt that the new strings in this .pot will have time to be landed in trunk, picked up by the WPCOM job when its cron will run, sent to GlotPress / translators, then be translated all in time for the final release's planned date of tomorrow Aug 14 🙃

This means that all those new strings that were introduced in PRs landed in trunk after Aug 6, and that we see added in this PR's .pot, will likely stay untranslated in the final release of Studio 1.18.0 (unless you translate them with AI in GlotPress in a hurry or something…).
Probably not dramatic / not a big deal (I'm assuming that in those cases the Electron runtime falls back to the English when there's no translation, as most other runtimes do), but worth being aware of \cc @bcotrim

@AliSoftware
AliSoftware merged commit 00a7bf4 into release/1.18.0 Aug 13, 2026
13 checks passed
@AliSoftware
AliSoftware deleted the release-1.18.0-regenerate-pot branch August 13, 2026 21:36
@bcotrim bcotrim mentioned this pull request Aug 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants