Regenerate bundle-strings.pot after #4536 resync of release/1.18.0 from trunk - #4541
Conversation
Re-running `bundle exec fastlane generate_pot_file` after #4536 merged `trunk` into the `release/1.18.0` branch, in order to make sure the `.pot` file that will be sent to translation picks up any latest strings that might have been added to `trunk` since the original code freeze that did it in 0d4d002
a47e09f to
15b0327
Compare
📊 Performance Test ResultsComparing 7aa5d3c vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
bcotrim
left a comment
There was a problem hiding this comment.
Changes look good, thanks 👍
|
Important The new strings added in this updated Given this, I doubt that the new strings in this This means that all those new strings that were introduced in PRs landed in |
Related issues
N/A
How AI was used in this PR
No AI was
harmedused in the making of this PRProposed Changes
Resynchronizing
bundle-strings.potafter #4536Why? / Context
The team recently decided to delay the Studio release
1.18.0to Friday, Aug 14, and as a result merged all the recent commits fromtrunkintorelease/1.18.0(via #4536) to incoroprate all the latest features/fixes fromtrunkin that1.18.0release.As discussed in #4536 (comment), because this was done by merging
trunkinto the existingrelease/1.18.0(that had been cut during the code-freeze one week ago on Aug 6)—as opposed to therelease/1.18.0branch being deleted and the code-freeze being re-done from scratch—this means that thegenerate_pot_fileaction that is usually called duringcode_freeze, to generate thebundle-strings.potfile with strings to be sent for translation, was not called again, and thatbundle-strings.potfile was thus not updated with any new string that might have been added intrunksince Aug 6.How? / The fix
To fix that, I've run
npm install && bundle exec fastlane generate_pot_filefrom therelease/1.18.0manually (after #4536 got merged) to update thebundle-strings.pot, resulting the diff in this PR.Note that I've encountered the
The await using declaration should be first transformed by `@babel/plugin-transform-explicit-resource-management`errors in the logs when running this lane on my machine, but this is an unrelated known issue, for which there's already a Draft PR #4467Testing Instructions
N/A Just check the diff makes sense
Pre-merge Checklist