Build PHP binaries --with-suggested-libs - #4502
Conversation
bcotrim
left a comment
There was a problem hiding this comment.
LGTM 👍
It would be interesting to compare the binaries size once we run the builds, assuming suggested libs can add libs we didn't have initially
| "$static_extensions" | ||
| # Give gd JPEG/WebP image support and FreeType (TrueType text). | ||
| --with-libs=freetype,libjpeg,libwebp | ||
| --with-suggested-libs |
There was a problem hiding this comment.
I followed the trail correctly, it looks like this change fails in the Linux GHA environments.
Given the PR is approved, I'm going to request changes just to avoid it's accidentally merged.
I haven't verified it myself, but when I asked Claude to check on the GHA status for the changes here, it read your comment and reported:
|
Related issues
How AI was used in this PR
N/A
Proposed Changes
static-php-cli omits certain external libraries by default, like libjpeg. These are listed as "suggestions" rather than "dependencies". We previously ran into trouble with the PHP gd module missing some external libraries and fixed it in #3927.
However, it turns out that there's a better approach to including these external libraries than the one we took in the previous PR. Instead of explicitly listing which libraries to include, we can use
--with-suggested-libsto have static-php-cli automatically include the suggested libraries. This PR makes that change.Testing Instructions
I will manually trigger a PHP build and verify that gd still has all the libraries we need.
Pre-merge Checklist