Skip to content

Preserve native image lowering in geometry coalescing tests - #4299

Merged
chubes4 merged 3 commits into
trunkfrom
fix/issue-4255-blocks-engine-2
Nov 4, 2026
Merged

chubes4 merged 3 commits into
trunkfrom
fix/issue-4255-blocks-engine-2

Conversation

@chubes4

@chubes4 chubes4 commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fixed the CI regressions while preserving native captured media. Composer tests, visual parity tests, and the whole-site acceptance gate pass; collateral reports zero changes.

What changed

  • Preserved existing behavior for interactive hosts, ordinary block hosts, and unknown host metadata.
  • Kept captured image metadata hosts editable as native images within retained shells.
  • Restored conservative contract expectations and added public-interface regression coverage.

Verification

  • (cd php-transformer && composer test:canonical && cd tools/visual-parity && npm ci --silent && npm test) && bash "$ACCEPT_GATE" passed on 1fd638d. Base trunk@d9cf41e advanced to 0f51705.
  • CI: pending
Cook run
  • Gate 1: tree 3f2fd988745cb11b6eb5e4c12d935b7f0c752346
  • Publication identity: ambient_gh

Tool: Homeboy (pi) · Model: gpt-6.1-sol

Relates to #4299

@chubes4

chubes4 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Not merging yet. This head (99468573) clears the companion predicate on / and /about/. On a whole import of the capture compared with its trunk base (b17bd6af), three home-page images no longer render at their size at any width:

width before (base) after (this head)
390 347×322, 348×322, 348×322 227×253, 231×253, 348×198
768 684×634, 685×634, 685×634 227×253, 231×253, 0×0
1440 324×361, 330×361, 706×401 227×253, 231×253, 494×281

The images are group1000007315, untitledtopazimageupscale… and image989842. The Wix host sizes its image to the host box, and the lowered core/image carries a fixed intrinsic size instead. The header logo survives (85×17, now named homepage.png).

The loop's collateral gate now checks rendered image size parity for every finding (static-site-importer 55d67e45). The next pass continues on this branch with that report.

AI assistance: Claude Opus (Pi, via Roadie/Franklin) ran the whole-site comparison on the Lab.

@chubes4
chubes4 marked this pull request as draft November 4, 2026 14:52
@chubes4
chubes4 marked this pull request as ready for review November 4, 2026 15:51
@chubes4
chubes4 merged commit 687620e into trunk Nov 4, 2026
15 checks passed
@chubes4
chubes4 deleted the fix/issue-4255-blocks-engine-2 branch November 4, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant