Simplify export-system-logs article - #190
Merged
Merged
Conversation
The article was 3313 words against a section median of 498 - the longest in Setup & maintenance by 3x, and much of the length was ClickHouse internals that an operator does not need: SystemLogQueue::pop() and queue->confirm() semantics, C++ stack traces, and a measurement table justifying the findings rather than stating them. Cut to 1278 words. Every tested recipe is kept; the reasoning behind them is replaced by the operational rule. - Replace the flush-mechanism explanation with the consequence: a failed flush is not retried, so the rows are gone. - Drop both stack traces and the push-time vs sink-construction analysis. The rule that matters is "S3 target failures lose local rows, URL target failures do not". - Collapse the 4-row measurement table into one sentence with the same numbers. - Drop the reconciliation / Distributed-sender section - design prose that made no tested claim. - Merge the References list into Related resources. - Reflow the DDL onto fewer lines. All four DDL blocks were re-executed verbatim on 26.7.5.10 after the reflow, plus the glob read-back, monitoring and upgrade-check queries: object sequence, session event types, file append and dependency output all match what the article states. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AsB1E5eSBXpaZT4jGzY57L
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #189. The article read like an investigation writeup rather than a KB page.
3313 words → 1278. For context, the median article in
altinity-kb-setup-and-maintenanceis 498 words and the previous longest was 1049 — #189 landed at 3× the section's longest.What was cut
The removed material was ClickHouse internals that don't help someone configuring an export:
SystemLogQueue::pop(),result.logs.swap(queue),queue->confirm()— replaced by the only part an operator acts on: a failed flush is not retried, so those rows are gone.Distributed-sender section — design prose that made no tested claim.What was kept
Every tested recipe, unchanged in substance: the S3 export (with the settings-placement warning, which is the article's most practically valuable part), session log, URL, File, the direct external engine, the monitoring query, the post-upgrade dependency check, and the version table.
Verification
The DDL was reflowed onto fewer lines, so it was re-tested rather than assumed. All four SQL blocks were extracted from the article and executed verbatim on 26.7.5.10 against MinIO, followed by the glob read-back, monitoring and upgrade-check queries. Object sequence (
query-log.ndjson,.1,.2, ...), all three session event types includingLoginFailure, the appending file target, and the dependency output all match what the article claims.SystemLogErrorOnFlushstayed empty throughout.Hugo build (0.128.2, CI-pinned): 328 pages, no shortcode leakage, anchor and both internal links resolve.
🤖 Generated with Claude Code
https://claude.ai/code/session_01AsB1E5eSBXpaZT4jGzY57L