Skip to content

[Trigger,PWGEM] Fix includes #17786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkucera wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −0
Open

[Trigger,PWGEM] Fix includes #17786

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions EventFiltering/PWGEM/globalDimuonFilter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in EventFiltering/PWGEM/globalDimuonFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)

Check failure on line 1 in EventFiltering/PWGEM/globalDimuonFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -57,11 +57,13 @@
#include <utility>
#include <vector>

#include <math.h>

struct globalDimuonFilter {
o2::framework::Produces<o2::aod::GlobalDimuonFilters> tags;

// Configurables
o2::framework::Configurable<std::string> ccdburl{"ccdb-url", "http://alice-ccdb.cern.ch", "url of the ccdb repository"};

Check failure on line 66 in EventFiltering/PWGEM/globalDimuonFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
o2::framework::Configurable<std::string> grpmagPath{"grpmagPath", "GLO/Config/GRPMagField", "CCDB path of the GRPMagField object"};
o2::framework::Configurable<std::string> geoPath{"geoPath", "GLO/Config/GeometryAligned", "Path of the geometry file"};
o2::framework::Configurable<int> minNmuon{"minNmuon", 2, "min number of global muon candidates per collision"};
Expand Down Expand Up @@ -1349,5 +1351,5 @@
o2::framework::WorkflowSpec defineDataProcessing(o2::framework::ConfigContext const& cfg)
{
return o2::framework::WorkflowSpec{
adaptAnalysisTask<globalDimuonFilter>(cfg, o2::framework::TaskName{"em-global-dimuon-filter"})};

Check failure on line 1354 in EventFiltering/PWGEM/globalDimuonFilter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task] 

Specified task name em-global-dimuon-filter produces device name em-global-dimuon-filter which does not match the device name global-dimuon-filter from the struct name globalDimuonFilter. (Matching struct name EmGlobalDimuonFilter)
}
Loading